[PATCH] dec/tulip:fix repeated words in comments

Subsystems: networking drivers, the rest, tulip network drivers

STALE1523d

2 messages, 2 authors, 2022-06-30 · open the first message on its own page

[PATCH] dec/tulip:fix repeated words in comments

From: Jilin Yuan <hidden>
Date: 2022-06-29 09:54:50

Delete the redundant word 'this'.

Signed-off-by: Jilin Yuan <redacted>
---
 drivers/net/ethernet/dec/tulip/xircom_cb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/xircom_cb.c b/drivers/net/ethernet/dec/tulip/xircom_cb.c
index 8759f9f76b62..61825c9bd6be 100644
--- a/drivers/net/ethernet/dec/tulip/xircom_cb.c
+++ b/drivers/net/ethernet/dec/tulip/xircom_cb.c
@@ -742,7 +742,7 @@ static void activate_receiver(struct xircom_private *card)
 
 /*
 deactivate_receiver disables the receiver on the card.
-To achieve this this code disables the receiver first;
+To achieve this code disables the receiver first;
 then it waits for the receiver to become inactive.
 
 must be called with the lock held and interrupts disabled.
@@ -829,7 +829,7 @@ static void activate_transmitter(struct xircom_private *card)
 
 /*
 deactivate_transmitter disables the transmitter on the card.
-To achieve this this code disables the transmitter first;
+To achieve this code disables the transmitter first;
 then it waits for the transmitter to become inactive.
 
 must be called with the lock held and interrupts disabled.
-- 
2.36.1

Re: [PATCH] dec/tulip:fix repeated words in comments

From: Helge Deller <deller@gmx.de>
Date: 2022-06-30 06:23:15

On 6/29/22 11:54, Jilin Yuan wrote:
quoted hunk
Delete the redundant word 'this'.

Signed-off-by: Jilin Yuan <redacted>
---
 drivers/net/ethernet/dec/tulip/xircom_cb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/xircom_cb.c b/drivers/net/ethernet/dec/tulip/xircom_cb.c
index 8759f9f76b62..61825c9bd6be 100644
--- a/drivers/net/ethernet/dec/tulip/xircom_cb.c
+++ b/drivers/net/ethernet/dec/tulip/xircom_cb.c
@@ -742,7 +742,7 @@ static void activate_receiver(struct xircom_private *card)

 /*
 deactivate_receiver disables the receiver on the card.
-To achieve this this code disables the receiver first;
+To achieve this code disables the receiver first;
No.
Instead it should be something like:
To achieve this, this code disables the receiver first; ...

but better look at the whole comment including the next line,
in which case it could become:

Disable the receiver first, then wait for it to become inactive.

...
quoted hunk
 then it waits for the receiver to become inactive.

 must be called with the lock held and interrupts disabled.
@@ -829,7 +829,7 @@ static void activate_transmitter(struct xircom_private *card)

 /*
 deactivate_transmitter disables the transmitter on the card.
-To achieve this this code disables the transmitter first;
+To achieve this code disables the transmitter first;
 then it waits for the transmitter to become inactive.
same here...

 must be called with the lock held and interrupts disabled.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help