Re: [PATCH net-next v7 0/2] axienet NAPI improvements

On Thu, 2022-05-12 at 11:18 -0600, Robert Hancock wrote:

Changes to support TX NAPI in the axienet driver, as well as fixing
a potential concurrency issue in the TX ring pointer handling.

Supersedes v5 of the individual patch
"net: axienet: Use NAPI for TX completion path".

Changed since v6: Use READ_ONCE where the value actually does need to
be read once, in axienet_check_tx_bd_space, not in axienet_start_xmit
where it doesn't.

Changed since v5: Replaced spinlock with fixes to the way the TX ring
tail pointer is updated, and broke those changes into a separate patch.

Changed since v4: Added locking to protect TX ring tail pointer against
concurrent access by TX transmit and TX poll paths.

Changed since v3: Fixed references to renamed function in comments

Changed since v2: Use separate TX and RX NAPI poll handlers to keep
completion handling on same CPU as TX/RX IRQ. Added hard/soft IRQ
benchmark information to commit message.

Changed since v1: Added benchmark information to commit message, no
code changes.

Robert Hancock (2):
  net: axienet: Be more careful about updating tx_bd_tail
  net: axienet: Use NAPI for TX completion path

 drivers/net/ethernet/xilinx/xilinx_axienet.h  |  54 +++---
 .../net/ethernet/xilinx/xilinx_axienet_main.c | 168 ++++++++++--------
 2 files changed, 126 insertions(+), 96 deletions(-)

Looking at Patchwork and Lore, seems like this cover letter may not have made
it to the list, though the two patches did? Can resend if it doesn't eventually
show up..

-- 
Robert Hancock
Senior Hardware Designer, Calian Advanced Technologies
www.calian.com

On Thu, 12 May 2022 23:00:02 +0000 Robert Hancock wrote:

Looking at Patchwork and Lore, seems like this cover letter may not have made
it to the list, though the two patches did? Can resend if it doesn't eventually
show up..

I may be wrong but I think it's fine, the cover letter doesn't have
much extra info, lore will catch you quoting it here and thread that
with the patches.