[PATCH bpf] selftests/bpf: remove unused variable from bpf_sk_assign test

Subsystems: bpf [general] (safe dynamic programs and tools), bpf [selftests] (test runners & infrastructure), kernel selftest framework, the rest

STALE1620d LANDED

Landed in mainline as fe4625d8b053 on 2022-04-01.

2 messages, 2 authors, 2022-04-01 · open the first message on its own page

[PATCH bpf] selftests/bpf: remove unused variable from bpf_sk_assign test

From: Eyal Birger <hidden>
Date: 2022-03-29 15:49:34

Was never used in bpf_sk_assign_test(), and was removed from
handle_{tcp,udp} in commit 0b9ad56b1ea6
("selftests/bpf: Use SOCKMAP for server sockets in bpf_sk_assign test")

Fixes: 0b9ad56b1ea6 ("selftests/bpf: Use SOCKMAP for server sockets in bpf_sk_assign test")
Signed-off-by: Eyal Birger <redacted>
---
 tools/testing/selftests/bpf/progs/test_sk_assign.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/test_sk_assign.c b/tools/testing/selftests/bpf/progs/test_sk_assign.c
index 02f79356d5eb..98c6493d9b91 100644
--- a/tools/testing/selftests/bpf/progs/test_sk_assign.c
+++ b/tools/testing/selftests/bpf/progs/test_sk_assign.c
@@ -89,7 +89,6 @@ get_tuple(struct __sk_buff *skb, bool *ipv4, bool *tcp)
 static inline int
 handle_udp(struct __sk_buff *skb, struct bpf_sock_tuple *tuple, bool ipv4)
 {
-	struct bpf_sock_tuple ln = {0};
 	struct bpf_sock *sk;
 	const int zero = 0;
 	size_t tuple_len;
@@ -121,7 +120,6 @@ handle_udp(struct __sk_buff *skb, struct bpf_sock_tuple *tuple, bool ipv4)
 static inline int
 handle_tcp(struct __sk_buff *skb, struct bpf_sock_tuple *tuple, bool ipv4)
 {
-	struct bpf_sock_tuple ln = {0};
 	struct bpf_sock *sk;
 	const int zero = 0;
 	size_t tuple_len;
@@ -161,7 +159,7 @@ handle_tcp(struct __sk_buff *skb, struct bpf_sock_tuple *tuple, bool ipv4)
 SEC("tc")
 int bpf_sk_assign_test(struct __sk_buff *skb)
 {
-	struct bpf_sock_tuple *tuple, ln = {0};
+	struct bpf_sock_tuple *tuple;
 	bool ipv4 = false;
 	bool tcp = false;
 	int tuple_len;
-- 
2.32.0

Re: [PATCH bpf] selftests/bpf: remove unused variable from bpf_sk_assign test

From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-04-01 20:50:18

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann [off-list ref]:

On Tue, 29 Mar 2022 18:49:14 +0300 you wrote:
Was never used in bpf_sk_assign_test(), and was removed from
handle_{tcp,udp} in commit 0b9ad56b1ea6
("selftests/bpf: Use SOCKMAP for server sockets in bpf_sk_assign test")

Fixes: 0b9ad56b1ea6 ("selftests/bpf: Use SOCKMAP for server sockets in bpf_sk_assign test")
Signed-off-by: Eyal Birger <redacted>

[...]
Here is the summary with links:
  - [bpf] selftests/bpf: remove unused variable from bpf_sk_assign test
    https://git.kernel.org/bpf/bpf-next/c/fe4625d8b053

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help