# \[PATCH v2\] tracing: Set user\_events to BROKEN

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2022-03-30 19:58:44 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/03/1721383
- Thread: https://ratatoskr.run/bpf/2022/03/1721383/t.md

```text
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

After being merged, user_events become more visible to a wider audience
that have concerns with the current API. It is too late to fix this for
this release, but instead of a full revert, just mark it as BROKEN (which
prevents it from being selected in make config). Then we can work finding
a better API. If that fails, then it will need to be completely reverted.

Link: https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com/

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
Changes since v1: https://lore.kernel.org/all/20220329222514.51af6c07@gandalf.local.home/
 - Add depends on COMPILE_TEST too (Linus Torvalds)

 Hopefully, no distro is idiotic enough to enable COMPILE_TEST in their
 builds to get this feature.

 kernel/trace/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 16a52a71732d..f83d29adb375 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -741,6 +741,7 @@ config USER_EVENTS
 	bool "User trace events"
 	select TRACING
 	select DYNAMIC_EVENTS
+	depends on BROKEN || COMPILE_TEST # API needs to be straighten out
 	help
 	  User trace events are user-defined trace events that
 	  can be used like an existing kernel trace event.  User trace
-- 
2.35.1
```
