# Re: \[PATCH net v2 2/3\] vsock/virtio: initialize vdev-\>priv before using VQs

- From: Stefan Hajnoczi \<stefanha@redhat.com\>
- Date: 2022-03-23 13:45:32 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/03/1713855
- Thread: https://ratatoskr.run/netdev/2022/03/1713614/t.md

```text
On Wed, Mar 23, 2022 at 09:49:53AM +0100, Stefano Garzarella wrote:
> When we fill VQs with empty buffers and kick the host, it may send
> an interrupt. `vdev->priv` must be initialized before this since it
> is used in the virtqueue callback.
> 
> Fixes: 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock")
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  net/vmw_vsock/virtio_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index b1962f8cd502..fff67ad39087 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -622,6 +622,7 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
>  	INIT_WORK(&vsock->event_work, virtio_transport_event_work);
>  	INIT_WORK(&vsock->send_pkt_work, virtio_transport_send_pkt_work);
>  
> +	vdev->priv = vsock;
>  	virtio_device_ready(vdev);

Doh, patch order got me. :)

Stefan
```

## Attachments

- [signature.asc](https://ratatoskr.run/netdev/2022/03/1713855/attachment/0) (application/pgp-signature, 488 bytes)