[PATCH -next] ethernet: 8390: Remove unnecessary print function dev_err()

Subsystems: 8390 network drivers [ne2000, 3c503, etc.], networking drivers, the rest

STALE1642d LANDED

Landed in mainline as d59c85ddacb3 on 2022-03-12.

2 messages, 2 authors, 2022-03-12 · open the first message on its own page

[PATCH -next] ethernet: 8390: Remove unnecessary print function dev_err()

From: Yang Li <hidden>
Date: 2022-03-11 00:18:05

The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warning:
./drivers/net/ethernet/8390/mcf8390.c:414:2-9: line 414 is redundant
because platform_get_irq() already prints an error

Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---
 drivers/net/ethernet/8390/mcf8390.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/8390/mcf8390.c b/drivers/net/ethernet/8390/mcf8390.c
index 90cd7bdf06f5..21047ae1bc3d 100644
--- a/drivers/net/ethernet/8390/mcf8390.c
+++ b/drivers/net/ethernet/8390/mcf8390.c
@@ -410,10 +410,8 @@ static int mcf8390_probe(struct platform_device *pdev)
 	int ret, irq;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "no IRQ specified?\n");
+	if (irq < 0)
 		return -ENXIO;
-	}
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (mem == NULL) {
-- 
2.20.1.7.g153144c

Re: [PATCH -next] ethernet: 8390: Remove unnecessary print function dev_err()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-03-12 07:10:20

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Fri, 11 Mar 2022 08:17:56 +0800 you wrote:
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warning:
./drivers/net/ethernet/8390/mcf8390.c:414:2-9: line 414 is redundant
because platform_get_irq() already prints an error

[...]
Here is the summary with links:
  - [-next] ethernet: 8390: Remove unnecessary print function dev_err()
    https://git.kernel.org/netdev/net-next/c/d59c85ddacb3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help