[PATCH] ethtool: add the memory free operation after send_ioctl call fails
From: Jie Wang <hidden>
Date: 2022-03-07 08:14:24
Subsystem:
the rest · Maintainer:
Linus Torvalds
The memory is not freed after send_ioctl fails in function do_gtunable and
do_stunable. This will cause memory leaks.
So this patch adds memory free operation after send_ioctl call fails.
Fixes: b717ed22d984 ("ethtool: add support for get/set ethtool_tunable")
Signed-off-by: Jie Wang <redacted>
---
ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 5d718a2..0fbb96b 100644
--- a/ethtool.c
+++ b/ethtool.c@@ -5097,6 +5097,7 @@ static int do_stunable(struct cmd_context *ctx) ret = send_ioctl(ctx, tuna); if (ret) { perror(tunable_strings[tuna->id]); + free(tuna); return ret; } free(tuna);
@@ -5174,6 +5175,7 @@ static int do_gtunable(struct cmd_context *ctx) ret = send_ioctl(ctx, tuna); if (ret) { fprintf(stderr, "%s: Cannot get tunable\n", ts); + free(tuna); return ret; } print_tunable(tuna);
--
2.33.0