[PATCH][next] brcmfmac: of: remove redundant variable len

Subsystems: broadcom brcm80211 ieee802.11 wireless drivers, the rest

STALE1674d LANDED

Landed in mainline as 2fd6d2ef6860 on 2022-02-10.

2 messages, 2 authors, 2022-02-10 · open the first message on its own page

[PATCH][next] brcmfmac: of: remove redundant variable len

From: Colin Ian King <hidden>
Date: 2022-02-07 13:52:47

The variable len is being assigned bit is never used. The variable
and the strlen call are redundant and can be removed.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index 5708de1d9f26..8623bde5eb70 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -71,14 +71,13 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
 	/* Set board-type to the first string of the machine compatible prop */
 	root = of_find_node_by_path("/");
 	if (root) {
-		int i, len;
+		int i;
 		char *board_type;
 		const char *tmp;
 
 		of_property_read_string_index(root, "compatible", 0, &tmp);
 
 		/* get rid of '/' in the compatible string to be able to find the FW */
-		len = strlen(tmp) + 1;
 		board_type = devm_kstrdup(dev, tmp, GFP_KERNEL);
 		if (!board_type) {
 			of_node_put(root);
-- 
2.34.1

Re: [PATCH][next] brcmfmac: of: remove redundant variable len

From: Kalle Valo <kvalo@kernel.org>
Date: 2022-02-10 08:47:12

Colin Ian King [off-list ref] wrote:
The variable len is being assigned bit is never used. The variable
and the strlen call are redundant and can be removed.

Signed-off-by: Colin Ian King <redacted>
Patch applied to wireless-next.git, thanks.

2fd6d2ef6860 brcmfmac: of: remove redundant variable len

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220207133329.336664-1-colin.i.king@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help