# Re: \[PATCH 04/54\] net: mellanox: fix open-coded for\_each\_set\_bit()

- From: Tariq Toukan \<hidden\>
- Date: 2022-01-26 09:01:41 
- List: netdev
- Page: https://ratatoskr.run/netdev/2022/01/1648077
- Thread: https://ratatoskr.run/netdev/2022/01/1641240/t.md

```text


On 1/23/2022 8:38 PM, Yury Norov wrote:
> Mellanox driver has an open-coded for_each_set_bit(). Fix it.
>
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/cmd.c | 23 ++++++-----------------
>   1 file changed, 6 insertions(+), 17 deletions(-)
>

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

Thanks,
Tariq
```