Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary)
From: Sergey Shtylyov <hidden>
Date: 2022-01-19 10:56:25
Also in:
alsa-devel, kvm, linux-edac, linux-gpio, linux-i2c, linux-iio, linux-mediatek, linux-mmc, linux-phy, linux-pm, linux-pwm, linux-renesas-soc, linux-serial, linux-spi, lkml, platform-driver-x86
On 1/18/22 12:18 PM, Uwe Kleine-König wrote:
On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote:quoted
On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote:quoted
A possible compromise: We can have both. We rename platform_get_irq_optional() to platform_get_irq_silent() (or platform_get_irq_silently() if this is preferred) and once all users are are changed (which can be done mechanically), we reintroduce a platform_get_irq_optional() with Sergey's suggested semantic (i.e. return 0 on not-found, no error message printking).Please do not do that as anyone trying to forward-port an old driver will miss the abi change of functionality and get confused. Make build-breaking changes, if the way a function currently works is changed in order to give people a chance.Fine for me. I assume this is a Nack for Sergey's patch?
Which patch do you mean? I'm starting to get really muddled... :-(
Best regards Uwe
MBR, Sergey