[PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

Subsystems: bpf [general] (safe dynamic programs and tools), bpf [selftests] (test runners & infrastructure), kernel selftest framework, the rest

STALE1662d LANDED

Landed in mainline as e80f2a0d1946 on 2022-01-15.

3 messages, 3 authors, 2022-01-15 · open the first message on its own page

[PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

From: <hidden>
Date: 2022-01-13 03:17:09

From: Menglong Dong <redacted>

'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
used, just remove them.

Signed-off-by: Menglong Dong <redacted>
---
 tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
index 95d5b941bc1f..c9abfe3a11af 100644
--- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
+++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
@@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb)
 {
 	void *data_end = (void *)(long) skb->data_end;
 	void *data = (void *)(long) skb->data;
-	__u32 lport = skb->local_port;
-	__u32 rport = skb->remote_port;
 	__u8 *d = data;
 	int err;
 
-- 
2.34.1

Re: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

From: Song Liu <song@kernel.org>
Date: 2022-01-13 17:07:50

On Wed, Jan 12, 2022 at 7:17 PM [off-list ref] wrote:
From: Menglong Dong <redacted>

'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
used, just remove them.

Signed-off-by: Menglong Dong <redacted>
Acked-by: Song Liu <redacted>
quoted hunk
---
 tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
index 95d5b941bc1f..c9abfe3a11af 100644
--- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
+++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
@@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb)
 {
        void *data_end = (void *)(long) skb->data_end;
        void *data = (void *)(long) skb->data;
-       __u32 lport = skb->local_port;
-       __u32 rport = skb->remote_port;
        __u8 *d = data;
        int err;

--
2.34.1

Re: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-01-15 01:30:13

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko [off-list ref]:

On Thu, 13 Jan 2022 11:16:58 +0800 you wrote:
From: Menglong Dong <redacted>

'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
used, just remove them.

Signed-off-by: Menglong Dong <redacted>

[...]
Here is the summary with links:
  - [bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c
    https://git.kernel.org/bpf/bpf-next/c/e80f2a0d1946

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help