[PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY

Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
properly control MT7530 and MT7531 switch PHYs.

A noticeable change is that the behaviour of switchport interfaces going
up-down-up-down is no longer there.

Signed-off-by: Arınç ÜNAL <redacted>
---
 drivers/net/dsa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index 7b1457a6e327..c0c91440340a 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig

@@ -36,6 +36,7 @@ config NET_DSA_LANTIQ_GSWIP
 config NET_DSA_MT7530
 	tristate "MediaTek MT753x and MT7621 Ethernet switch support"
 	select NET_DSA_TAG_MTK
+	select MEDIATEK_GE_PHY
 	help
 	  This enables support for the MediaTek MT7530, MT7531, and MT7621
 	  Ethernet switch chips.

-- 
2.25.1

On Fri, Jan 28, 2022 at 08:05:45PM +0300, Arınç ÜNAL wrote:

Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
properly control MT7530 and MT7531 switch PHYs.

A noticeable change is that the behaviour of switchport interfaces going
up-down-up-down is no longer there.

Signed-off-by: Arınç ÜNAL <redacted>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

On 1/28/2022 9:05 AM, Arınç ÜNAL wrote:

Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
properly control MT7530 and MT7531 switch PHYs.

A noticeable change is that the behaviour of switchport interfaces going
up-down-up-down is no longer there.

Signed-off-by: Arınç ÜNAL <redacted>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

On Fri, 28 Jan 2022 20:05:45 +0300 Arınç ÜNAL wrote:

Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
properly control MT7530 and MT7531 switch PHYs.

A noticeable change is that the behaviour of switchport interfaces going
up-down-up-down is no longer there.

Signed-off-by: Arınç ÜNAL <redacted>

Sounds like a fix, can we get a Fixes tag?

On 29/01/2022 01:31, Jakub Kicinski wrote:

On Fri, 28 Jan 2022 20:05:45 +0300 Arınç ÜNAL wrote:

quoted

Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
properly control MT7530 and MT7531 switch PHYs.

A noticeable change is that the behaviour of switchport interfaces going
up-down-up-down is no longer there.

Signed-off-by: Arınç ÜNAL <redacted>

Sounds like a fix, can we get a Fixes tag?

Sent v2. I didn't realise you weren't in the recipients, sorry.

https://lore.kernel.org/netdev/20220129062703.595-1-arinc.unal@arinc9.com/T/#u

Arınç