[PATCH v2 0/2] net: phy: Fix doc build warning

STALE1765d LANDED

Landed in mainline as 9e8926888cf7 on 2021-12-08.

4 messages, 2 authors, 2021-12-08 · open the first message on its own page

[PATCH v2 0/2] net: phy: Fix doc build warning

From: Yanteng Si <hidden>
Date: 2021-12-06 08:13:56

v2:

* Modified Patch 1/2 under Akira's advices.

* Add Patch 2/2 to fix warning as:

Documentation/networking/kapi:147: ./drivers/net/phy/phylink.c:1657: WARNING: Unexpected indentation.
Documentation/networking/kapi:147: ./drivers/net/phy/phylink.c:1658: WARNING: Block quote ends without a blank line; unexpected unindent.

v1:(Patch 0001)

* Fix warning as:

linux-next/Documentation/networking/kapi:122: ./include/linux/phy.h:543: WARNING: Unexpected indentation.
linux-next/Documentation/networking/kapi:122: ./include/linux/phy.h:544: WARNING: Block quote ends without a blank line; unexpected unindent.
linux-next/Documentation/networking/kapi:122: ./include/linux/phy.h:546: WARNING: Unexpected indentation.

Yanteng Si (2):
  net: phy: Remove unnecessary indentation in the comments of phy_device
  net: phy: Add the missing blank line in the phylink_suspend comment

 drivers/net/phy/phylink.c |  1 +
 include/linux/phy.h       | 11 ++++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

-- 
2.27.0

[PATCH v2 1/2] net: phy: Remove unnecessary indentation in the comments of phy_device

From: Yanteng Si <hidden>
Date: 2021-12-06 08:14:00

From: Yanteng Si <redacted>

Fix warning as:

linux-next/Documentation/networking/kapi:122: ./include/linux/phy.h:543: WARNING: Unexpected indentation.
linux-next/Documentation/networking/kapi:122: ./include/linux/phy.h:544: WARNING: Block quote ends without a blank line; unexpected unindent.
linux-next/Documentation/networking/kapi:122: ./include/linux/phy.h:546: WARNING: Unexpected indentation.

Signed-off-by: Yanteng Si <redacted>
---
 include/linux/phy.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 1e57cdd95da3..6de8d7a90d78 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -538,11 +538,12 @@ struct macsec_ops;
  * @mac_managed_pm: Set true if MAC driver takes of suspending/resuming PHY
  * @state: State of the PHY for management purposes
  * @dev_flags: Device-specific flags used by the PHY driver.
- *		Bits [15:0] are free to use by the PHY driver to communicate
- *			    driver specific behavior.
- *		Bits [23:16] are currently reserved for future use.
- *		Bits [31:24] are reserved for defining generic
- *			     PHY driver behavior.
+ *
+ *      - Bits [15:0] are free to use by the PHY driver to communicate
+ *        driver specific behavior.
+ *      - Bits [23:16] are currently reserved for future use.
+ *      - Bits [31:24] are reserved for defining generic
+ *        PHY driver behavior.
  * @irq: IRQ number of the PHY's interrupt (-1 if none)
  * @phy_timer: The timer for handling the state machine
  * @phylink: Pointer to phylink instance for this PHY
-- 
2.27.0

[PATCH v2 2/2] net: phy: Add the missing blank line in the phylink_suspend comment

From: Yanteng Si <hidden>
Date: 2021-12-06 08:14:07

Fix warning as:

Documentation/networking/kapi:147: ./drivers/net/phy/phylink.c:1657: WARNING: Unexpected indentation.
Documentation/networking/kapi:147: ./drivers/net/phy/phylink.c:1658: WARNING: Block quote ends without a blank line; unexpected unindent.

Signed-off-by: Yanteng Si <redacted>
---
 drivers/net/phy/phylink.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 8e3861f09b4f..c26884a56354 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -1653,6 +1653,7 @@ EXPORT_SYMBOL_GPL(phylink_stop);
  * @mac_wol: true if the MAC needs to receive packets for Wake-on-Lan
  *
  * Handle a network device suspend event. There are several cases:
+ *
  * - If Wake-on-Lan is not active, we can bring down the link between
  *   the MAC and PHY by calling phylink_stop().
  * - If Wake-on-Lan is active, and being handled only by the PHY, we
-- 
2.27.0

Re: [PATCH v2 0/2] net: phy: Fix doc build warning

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-08 05:50:14

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski [off-list ref]:

On Mon,  6 Dec 2021 16:12:26 +0800 you wrote:
v2:

* Modified Patch 1/2 under Akira's advices.

* Add Patch 2/2 to fix warning as:

Documentation/networking/kapi:147: ./drivers/net/phy/phylink.c:1657: WARNING: Unexpected indentation.
Documentation/networking/kapi:147: ./drivers/net/phy/phylink.c:1658: WARNING: Block quote ends without a blank line; unexpected unindent.

[...]
Here is the summary with links:
  - [v2,1/2] net: phy: Remove unnecessary indentation in the comments of phy_device
    https://git.kernel.org/netdev/net/c/a97770cc4016
  - [v2,2/2] net: phy: Add the missing blank line in the phylink_suspend comment
    https://git.kernel.org/netdev/net/c/c35e8de70456

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help