# Re: \[PATCH bpf-next 3/5\] selftests/bpf: factor out common helpers for benchmarks

- From: Hou Tao \<hidden\>
- Date: 2021-12-08 13:41:30 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/12/7788195
- Thread: https://ratatoskr.run/netdev/2021/11/7787449/t.md

```text
Hi,

On 12/7/2021 10:55 AM, Andrii Nakryiko wrote:
> On Tue, Nov 30, 2021 at 6:07 AM Hou Tao [ref] wrote:
>> Five helpers are factored out to reduce boilerplate for
>> benchmark tests: do_getpgid(), getpgid_loop_producer(),
>> assert_single_consumer(), assert_single_producer() and
>> noop_consumer().
>>
>> Signed-off-by: Hou Tao <redacted>
>> ---
> Please drop this patch. All the stuff you are extracting into
> "reusable" helpers is so trivial that it's not worth it. It just makes
> it harder to follow each individual benchmark's setup.
OK. Will do it v2.

```