[PATCH net-next] net: lantiq_etop: avoid precedence issues

Subsystems: networking drivers, the rest

STALE1745d

2 messages, 2 authors, 2021-12-30 · open the first message on its own page

[PATCH net-next] net: lantiq_etop: avoid precedence issues

From: Aleksander Jan Bajkowski <hidden>
Date: 2021-12-29 23:27:32

Add () around macro argument to avoid precedence issues

Signed-off-by: Aleksander Jan Bajkowski <redacted>
---
 drivers/net/ethernet/lantiq_etop.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 072391c494ce..db244c90a4cb 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -65,8 +65,8 @@
 /* use 2 static channels for TX/RX */
 #define LTQ_ETOP_TX_CHANNEL	1
 #define LTQ_ETOP_RX_CHANNEL	6
-#define IS_TX(x)		(x == LTQ_ETOP_TX_CHANNEL)
-#define IS_RX(x)		(x == LTQ_ETOP_RX_CHANNEL)
+#define IS_TX(x)		((x) == LTQ_ETOP_TX_CHANNEL)
+#define IS_RX(x)		((x) == LTQ_ETOP_RX_CHANNEL)
 
 #define ltq_etop_r32(x)		ltq_r32(ltq_etop_membase + (x))
 #define ltq_etop_w32(x, y)	ltq_w32(x, ltq_etop_membase + (y))
-- 
2.30.2

Re: [PATCH net-next] net: lantiq_etop: avoid precedence issues

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-30 13:30:30

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller [off-list ref]:

On Thu, 30 Dec 2021 00:27:25 +0100 you wrote:
Add () around macro argument to avoid precedence issues

Signed-off-by: Aleksander Jan Bajkowski <redacted>
---
 drivers/net/ethernet/lantiq_etop.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
  - [net-next] net: lantiq_etop: avoid precedence issues
    https://git.kernel.org/netdev/net-next/c/b1cb12a27134

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help