[PATCH net-next] net: lantiq_etop: add missing comment for wmb()

Subsystems: networking drivers, the rest

STALE1757d LANDED

Landed in mainline as 723955913e77 on 2021-12-28.

2 messages, 2 authors, 2021-12-29 · open the first message on its own page

[PATCH net-next] net: lantiq_etop: add missing comment for wmb()

From: Aleksander Jan Bajkowski <hidden>
Date: 2021-12-28 21:49:18

This patch adds the missing code comment for memory barrier
call and fixes checkpatch warning:

WARNING: memory barrier without comment
+	wmb();

Signed-off-by: Aleksander Jan Bajkowski <redacted>
---
 drivers/net/ethernet/lantiq_etop.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 072391c494ce..5d90cc147950 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -498,6 +498,7 @@ ltq_etop_tx(struct sk_buff *skb, struct net_device *dev)
 	spin_lock_irqsave(&priv->lock, flags);
 	desc->addr = ((unsigned int) dma_map_single(&priv->pdev->dev, skb->data, len,
 						DMA_TO_DEVICE)) - byte_offset;
+	/* Make sure the address is written before we give it to HW */
 	wmb();
 	desc->ctl = LTQ_DMA_OWN | LTQ_DMA_SOP | LTQ_DMA_EOP |
 		LTQ_DMA_TX_OFFSET(byte_offset) | (len & LTQ_DMA_SIZE_MASK);
-- 
2.30.2

Re: [PATCH net-next] net: lantiq_etop: add missing comment for wmb()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-29 00:20:17

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Tue, 28 Dec 2021 22:49:10 +0100 you wrote:
This patch adds the missing code comment for memory barrier
call and fixes checkpatch warning:

WARNING: memory barrier without comment
+	wmb();

Signed-off-by: Aleksander Jan Bajkowski <redacted>

[...]
Here is the summary with links:
  - [net-next] net: lantiq_etop: add missing comment for wmb()
    https://git.kernel.org/netdev/net-next/c/723955913e77

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help