[PATCH v2] drivers: net: smc911x: Check for error irq

On Thursday, December 23, 2021, Andy Shevchenko [off-list ref] wrote:

Do other way around.
ret = ...
if (ret < 0)
  ...
irq = ret;

This version I correct the patch by using error variable, too.
And the commit message is as follow.

Because platform_get_irq() could fail and return error irq.
Therefore, it might be better to check it in order to avoid the use of
error irq.

Fixes: ae150435b59e ("smsc: Move the SMC (SMSC) drivers")
Signed-off-by: Jiasheng Jiang <redacted>
---
Changlog:

v1 -> v2

*Change 1. Using error varaible to check.
---
 drivers/net/ethernet/smsc/smc911x.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c
index 22cdbf12c823..9470d9c07fed 100644
--- a/drivers/net/ethernet/smsc/smc911x.c
+++ b/drivers/net/ethernet/smsc/smc911x.c

@@ -2069,7 +2069,12 @@ static int smc911x_drv_probe(struct platform_device *pdev)
 	SET_NETDEV_DEV(ndev, &pdev->dev);
 
 	ndev->dma = (unsigned char)-1;
-	ndev->irq = platform_get_irq(pdev, 0);
+
+	ret = platform_get_irq(pdev, 0);
+	if (ret < 0)
+		goto release_both;
+	ndev->irq = ret;
+
 	lp = netdev_priv(ndev);
 	lp->netdev = ndev;
 #ifdef SMC_DYNAMIC_BUS_CONFIG

-- 
2.25.1

On Thu, Dec 23, 2021 at 2:33 PM Jiasheng Jiang [off-list ref] wrote:

On Thursday, December 23, 2021, Andy Shevchenko [off-list ref] wrote:

quoted

Do other way around.
ret = ...
if (ret < 0)
  ...
irq = ret;

This version I correct the patch by using error variable, too.
And the commit message is as follow.

Because platform_get_irq() could fail and return error irq.
Therefore, it might be better to check it in order to avoid the use of
error irq.

Fix commit message and send v3.

-- 
With Best Regards,
Andy Shevchenko