[PATCH] net/netfilter/x_tables.c: Use kvalloc to make your code better

Subsystems: netfilter, networking [general], the rest

STALE1767d

2 messages, 2 authors, 2021-12-10 · open the first message on its own page

[PATCH] net/netfilter/x_tables.c: Use kvalloc to make your code better

From: lizhe <hidden>
Date: 2021-12-10 03:13:56

Use kvzalloc () instead of kvmalloc () and memset

Signed-off-by: lizhe <redacted>
---
 net/netfilter/x_tables.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
index 25524e393349..8d6ffed7d526 100644
--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -1189,11 +1189,10 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size)
 	if (sz < sizeof(*info) || sz >= XT_MAX_TABLE_SIZE)
 		return NULL;
 
-	info = kvmalloc(sz, GFP_KERNEL_ACCOUNT);
+	info = kvzalloc(sz, GFP_KERNEL_ACCOUNT);
 	if (!info)
 		return NULL;
 
-	memset(info, 0, sizeof(*info));
 	info->size = size;
 	return info;
 }
-- 
2.25.1

Re: [PATCH] net/netfilter/x_tables.c: Use kvalloc to make your code better

From: Florian Westphal <fw@strlen.de>
Date: 2021-12-10 08:12:33

lizhe [off-list ref] wrote:
quoted hunk
Use kvzalloc () instead of kvmalloc () and memset

Signed-off-by: lizhe <redacted>
---
 net/netfilter/x_tables.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
index 25524e393349..8d6ffed7d526 100644
--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -1189,11 +1189,10 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size)
 	if (sz < sizeof(*info) || sz >= XT_MAX_TABLE_SIZE)
 		return NULL;
 
-	info = kvmalloc(sz, GFP_KERNEL_ACCOUNT);
+	info = kvzalloc(sz, GFP_KERNEL_ACCOUNT);
 	if (!info)
 		return NULL;
 
-	memset(info, 0, sizeof(*info));
sz != sizeof(*info)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help