[PATCH core-next] net/core: remove unneeded variable
Subsystems:
networking [general], networking [ipv4/ipv6], the rest
STALE1778d
2 messages,
2 authors,
2021-12-10 · open the first message on its own page
From: Minghao Chi <redacted>
Return status directly from function called.
Reported-by: Zeal Robot <redacted>
Signed-off-by: Minghao Chi <redacted>
---
net/core/lwtunnel.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index 2820aca2173a..c34248e358ac 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -63,11 +63,7 @@ static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type)
struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
{
- struct lwtunnel_state *lws;
-
- lws = kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
-
- return lws;
+ return kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
}
EXPORT_SYMBOL_GPL(lwtunnel_state_alloc);
--
2.25.1
On Fri, 10 Dec 2021 02:20:12 +0000 cgel.zte@gmail.com wrote:
quoted hunk
From: Minghao Chi <redacted>
Return status directly from function called.
Reported-by: Zeal Robot <redacted>
Signed-off-by: Minghao Chi <redacted>
---
net/core/lwtunnel.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index 2820aca2173a..c34248e358ac 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -63,11 +63,7 @@ static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type)
struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
{
- struct lwtunnel_state *lws;
-
- lws = kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
-
- return lws;
+ return kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
}
EXPORT_SYMBOL_GPL(lwtunnel_state_alloc);
I don't think any of your "remove unneeded variable" patches are worth
applying, sorry.
This one doesn't even build.