[PATCH] samples/bpf: fix swap.cocci warning

Subsystems: bpf [general] (safe dynamic programs and tools), the rest

STALE1760d

2 messages, 2 authors, 2021-12-09 · open the first message on its own page

[PATCH] samples/bpf: fix swap.cocci warning

From: Yihao Han <hidden>
Date: 2021-12-08 11:34:29

Fix following swap.cocci warning:
./samples/bpf/xsk_fwd.c:660:22-23:
WARNING opportunity for swap()

Signed-off-by: Yihao Han <redacted>
---
 samples/bpf/xsk_fwd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/samples/bpf/xsk_fwd.c b/samples/bpf/xsk_fwd.c
index 1cd97c84c337..e82582b225d3 100644
--- a/samples/bpf/xsk_fwd.c
+++ b/samples/bpf/xsk_fwd.c

@@ -653,9 +653,7 @@ static void swap_mac_addresses(void *data)
 	struct ether_addr *dst_addr = (struct ether_addr *)&eth->ether_dhost;
 	struct ether_addr tmp;
 
-	tmp = *src_addr;
-	*src_addr = *dst_addr;
-	*dst_addr = tmp;
+	swap(*src_addr, *dst_addr);
 }
 
 static void *

-- 
2.17.1

Re: [PATCH] samples/bpf: fix swap.cocci warning

From: Andrii Nakryiko <hidden>
Date: 2021-12-09 07:10:27

On Wed, Dec 8, 2021 at 3:34 AM Yihao Han [off-list ref] wrote:

quoted hunk

Fix following swap.cocci warning:
./samples/bpf/xsk_fwd.c:660:22-23:
WARNING opportunity for swap()

Signed-off-by: Yihao Han <redacted>
---
 samples/bpf/xsk_fwd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/samples/bpf/xsk_fwd.c b/samples/bpf/xsk_fwd.c
index 1cd97c84c337..e82582b225d3 100644
--- a/samples/bpf/xsk_fwd.c
+++ b/samples/bpf/xsk_fwd.c

@@ -653,9 +653,7 @@ static void swap_mac_addresses(void *data)
        struct ether_addr *dst_addr = (struct ether_addr *)&eth->ether_dhost;
        struct ether_addr tmp;

this variable needs to be removed as well then

-       tmp = *src_addr;
-       *src_addr = *dst_addr;
-       *dst_addr = tmp;
+       swap(*src_addr, *dst_addr);
 }

 static void *
--
2.17.1

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help