[PATCH] bpf: remove redundant assignment to pointer t

Subsystems: bpf [general] (safe dynamic programs and tools), the rest

STALE1761d LANDED

Landed in mainline as 73b6eae583f4 on 2021-12-09.

2 messages, 2 authors, 2021-12-09 · open the first message on its own page

[PATCH] bpf: remove redundant assignment to pointer t

From: Colin Ian King <hidden>
Date: 2021-12-07 22:47:24

The pointer t is being initialized with a value that is never read. The
pointer is re-assigned a value a littler later on, hence the initialization
is redundant and can be removed.

Signed-off-by: Colin Ian King <redacted>
---
 kernel/bpf/btf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 48cdf5b425a7..c70f80055b8e 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -836,7 +836,7 @@ static const char *btf_show_name(struct btf_show *show)
 	const char *ptr_suffix = &ptr_suffixes[strlen(ptr_suffixes)];
 	const char *name = NULL, *prefix = "", *parens = "";
 	const struct btf_member *m = show->state.member;
-	const struct btf_type *t = show->state.type;
+	const struct btf_type *t;
 	const struct btf_array *array;
 	u32 id = show->state.type_id;
 	const char *member = NULL;
-- 
2.33.1

Re: [PATCH] bpf: remove redundant assignment to pointer t

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-09 07:20:15

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko [off-list ref]:

On Tue,  7 Dec 2021 22:47:18 +0000 you wrote:
The pointer t is being initialized with a value that is never read. The
pointer is re-assigned a value a littler later on, hence the initialization
is redundant and can be removed.

Signed-off-by: Colin Ian King <redacted>
---
 kernel/bpf/btf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
  - bpf: remove redundant assignment to pointer t
    https://git.kernel.org/bpf/bpf-next/c/73b6eae583f4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help