[PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

Subsystems: can network drivers, the rest

STALE1734d LANDED

Landed in mainline as 68fa39ea9124 on 2022-01-05.

8 messages, 2 authors, 2022-01-05 · open the first message on its own page

[PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-02 20:59:51 

GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/can/spi/mcp251x.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
index 0579ab74f728..0cec808e8727 100644
--- a/drivers/net/can/spi/mcp251x.c
+++ b/drivers/net/can/spi/mcp251x.c
@@ -600,9 +600,6 @@ static int mcp251x_gpio_setup(struct mcp251x_priv *priv)
 	gpio->ngpio = ARRAY_SIZE(mcp251x_gpio_names);
 	gpio->names = mcp251x_gpio_names;
 	gpio->can_sleep = true;
-#ifdef CONFIG_OF_GPIO
-	gpio->of_node = priv->spi->dev.of_node;
-#endif
 
 	return devm_gpiochip_add_data(&priv->spi->dev, gpio, priv);
 }
-- 
2.33.0

Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-09 11:59:45 

On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:
GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.
Marc, what do you think about this change?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-12-10 13:06:23 

On 09.12.2021 13:58:40, Andy Shevchenko wrote:
On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:
quoted
GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.
Marc, what do you think about this change?
LGTM, added to linux-can-next/testing.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-10 13:20:34 

On Fri, Dec 10, 2021 at 02:06:07PM +0100, Marc Kleine-Budde wrote:
On 09.12.2021 13:58:40, Andy Shevchenko wrote:
quoted
On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:
...
quoted
Marc, what do you think about this change?
LGTM, added to linux-can-next/testing.
Thanks for applying this and hi311x patches!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2022-01-05 14:32:14 

On Fri, Dec 10, 2021 at 03:19:31PM +0200, Andy Shevchenko wrote:
On Fri, Dec 10, 2021 at 02:06:07PM +0100, Marc Kleine-Budde wrote:
quoted
On 09.12.2021 13:58:40, Andy Shevchenko wrote:
quoted
On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:
...
quoted
quoted
Marc, what do you think about this change?
LGTM, added to linux-can-next/testing.
Thanks for applying this and hi311x patches!
Can we have a chance to see it in the v5.17-rc1?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2022-01-05 14:34:59 

On 05.01.2022 16:21:13, Andy Shevchenko wrote:
On Fri, Dec 10, 2021 at 03:19:31PM +0200, Andy Shevchenko wrote:
quoted
On Fri, Dec 10, 2021 at 02:06:07PM +0100, Marc Kleine-Budde wrote:
quoted
On 09.12.2021 13:58:40, Andy Shevchenko wrote:
quoted
On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:
...
quoted
quoted
Marc, what do you think about this change?
LGTM, added to linux-can-next/testing.
Thanks for applying this and hi311x patches!
Can we have a chance to see it in the v5.17-rc1?
Yes:
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105

'about to send that PR.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2022-01-05 14:48:52 

On Wed, Jan 05, 2022 at 03:34:48PM +0100, Marc Kleine-Budde wrote:
On 05.01.2022 16:21:13, Andy Shevchenko wrote:
quoted
On Fri, Dec 10, 2021 at 03:19:31PM +0200, Andy Shevchenko wrote:
quoted
On Fri, Dec 10, 2021 at 02:06:07PM +0100, Marc Kleine-Budde wrote:
quoted
On 09.12.2021 13:58:40, Andy Shevchenko wrote:
quoted
On Thu, Dec 02, 2021 at 10:58:55PM +0200, Andy Shevchenko wrote:
...
quoted
quoted
Marc, what do you think about this change?
LGTM, added to linux-can-next/testing.
Thanks for applying this and hi311x patches!
Can we have a chance to see it in the v5.17-rc1?
Yes:
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105

'about to send that PR.
Cool, thanks! Happy new year!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] can: mcp251x: Get rid of duplicate of_node assignment

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2022-01-05 14:54:53 

On 05.01.2022 16:47:25, Andy Shevchenko wrote:
quoted
quoted
Can we have a chance to see it in the v5.17-rc1?
Yes:
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=linux-can-next-for-5.17-20220105

'about to send that PR.
Cool, thanks! Happy new year!
Thanks. Happy new year, too!

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help