The UniMAC MDIO controller integrated into GENET does not provide a
reg-names property since it is optional, reflect that in the binding.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 1 -
1 file changed, 1 deletion(-)
Add Doug and myself as maintainers since this binding is used by the
GENET Ethernet controller for its internal MDIO controller.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
1 file changed, 2 insertions(+)
MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores
and will be needed in order to convert GENET to YAML in subsequent
changes.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
1 file changed, 1 insertion(+)
@@ -1,125 +0,0 @@-* Broadcom BCM7xxx Ethernet Controller (GENET)--Required properties:-- compatible: should contain one of "brcm,genet-v1", "brcm,genet-v2",- "brcm,genet-v3", "brcm,genet-v4", "brcm,genet-v5", "brcm,bcm2711-genet-v5" or- "brcm,bcm7712-genet-v5".-- reg: address and length of the register set for the device-- interrupts and/or interrupts-extended: must be two cells, the first cell- is the general purpose interrupt line, while the second cell is the- interrupt for the ring RX and TX queues operating in ring mode. An- optional third interrupt cell for Wake-on-LAN can be specified.- See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt- for information on the property specifics.-- phy-mode: see ethernet.txt file in the same directory-- #address-cells: should be 1-- #size-cells: should be 1--Optional properties:-- clocks: When provided, must be two phandles to the functional clocks nodes- of the GENET block. The first phandle is the main GENET clock used during- normal operation, while the second phandle is the Wake-on-LAN clock.-- clock-names: When provided, names of the functional clock phandles, first- name should be "enet" and second should be "enet-wol".--- phy-handle: See ethernet.txt file in the same directory; used to describe- configurations where a PHY (internal or external) is used.--- fixed-link: When the GENET interface is connected to a MoCA hardware block or- when operating in a RGMII to RGMII type of connection, or when the MDIO bus is- voluntarily disabled, this property should be used to describe the "fixed link".- See Documentation/devicetree/bindings/net/fixed-link.txt for information on- the property specifics--Required child nodes:--- mdio bus node: this node should always be present regardless of the PHY- configuration of the GENET instance--MDIO bus node required properties:--- compatible: should contain one of "brcm,genet-mdio-v1", "brcm,genet-mdio-v2"- "brcm,genet-mdio-v3", "brcm,genet-mdio-v4", "brcm,genet-mdio-v5", the version- has to match the parent node compatible property (e.g: brcm,genet-v4 pairs- with brcm,genet-mdio-v4)-- reg: address and length relative to the parent node base register address-- #address-cells: address cell for MDIO bus addressing, should be 1-- #size-cells: size of the cells for MDIO bus addressing, should be 0--Ethernet PHY node properties:--See Documentation/devicetree/bindings/net/phy.txt for the list of required and-optional properties.--Internal Gigabit PHY example:--ethernet@f0b60000 {- phy-mode = "internal";- phy-handle = <&phy1>;- mac-address = [ 00 10 18 36 23 1a ];- compatible = "brcm,genet-v4";- #address-cells = <0x1>;- #size-cells = <0x1>;- reg = <0xf0b60000 0xfc4c>;- interrupts = <0x0 0x14 0x0>, <0x0 0x15 0x0>;-- mdio@e14 {- compatible = "brcm,genet-mdio-v4";- #address-cells = <0x1>;- #size-cells = <0x0>;- reg = <0xe14 0x8>;-- phy1: ethernet-phy@1 {- max-speed = <1000>;- reg = <0x1>;- compatible = "ethernet-phy-ieee802.3-c22";- };- };-};--MoCA interface / MAC to MAC example:--ethernet@f0b80000 {- phy-mode = "moca";- fixed-link = <1 0 1000 0 0>;- mac-address = [ 00 10 18 36 24 1a ];- compatible = "brcm,genet-v4";- #address-cells = <0x1>;- #size-cells = <0x1>;- reg = <0xf0b80000 0xfc4c>;- interrupts = <0x0 0x16 0x0>, <0x0 0x17 0x0>;-- mdio@e14 {- compatible = "brcm,genet-mdio-v4";- #address-cells = <0x1>;- #size-cells = <0x0>;- reg = <0xe14 0x8>;- };-};---External MDIO-connected Gigabit PHY/switch:--ethernet@f0ba0000 {- phy-mode = "rgmii";- phy-handle = <&phy0>;- mac-address = [ 00 10 18 36 26 1a ];- compatible = "brcm,genet-v4";- #address-cells = <0x1>;- #size-cells = <0x1>;- reg = <0xf0ba0000 0xfc4c>;- interrupts = <0x0 0x18 0x0>, <0x0 0x19 0x0>;-- mdio@e14 {- compatible = "brcm,genet-mdio-v4";- #address-cells = <0x1>;- #size-cells = <0x0>;- reg = <0xe14 0x8>;-- phy0: ethernet-phy@0 {- max-speed = <1000>;- reg = <0x0>;- compatible = "ethernet-phy-ieee802.3-c22";- };- };-};
@@ -1,30 +0,0 @@-Broadcom AMAC Ethernet Controller Device Tree Bindings----------------------------------------------------------------Required properties:- - compatible: "brcm,amac"- "brcm,nsp-amac"- "brcm,ns2-amac"- - reg: Address and length of the register set for the device. It- contains the information of registers in the same order as- described by reg-names- - reg-names: Names of the registers.- "amac_base": Address and length of the GMAC registers- "idm_base": Address and length of the GMAC IDM registers- (required for NSP and Northstar2)- "nicpm_base": Address and length of the NIC Port Manager- registers (required for Northstar2)- - interrupts: Interrupt number--The MAC address will be determined using the optional properties-defined in ethernet.txt.--Examples:--amac0: ethernet@18022000 {- compatible = "brcm,nsp-amac";- reg = <0x18022000 0x1000>,- <0x18110000 0x1000>;- reg-names = "amac_base", "idm_base";- interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;-};
@@ -1,38 +0,0 @@-* Broadcom BCM7xxx Ethernet Systemport Controller (SYSTEMPORT)--Required properties:-- compatible: should be one of:- "brcm,systemport-v1.00"- "brcm,systemportlite-v1.00" or- "brcm,systemport"-- reg: address and length of the register set for the device.-- interrupts: interrupts for the device, first cell must be for the rx- interrupts, and the second cell should be for the transmit queues. An- optional third interrupt cell for Wake-on-LAN can be specified-- local-mac-address: Ethernet MAC address (48 bits) of this adapter-- phy-mode: Should be a string describing the PHY interface to the- Ethernet switch/PHY, see Documentation/devicetree/bindings/net/ethernet.txt-- fixed-link: see Documentation/devicetree/bindings/net/fixed-link.txt for- the property specific details--Optional properties:-- systemport,num-tier2-arb: number of tier 2 arbiters, an integer-- systemport,num-tier1-arb: number of tier 1 arbiters, an integer-- systemport,num-txq: number of HW transmit queues, an integer-- systemport,num-rxq: number of HW receive queues, an integer-- clocks: When provided, must be two phandles to the functional clocks nodes of- the SYSTEMPORT block. The first phandle is the main SYSTEMPORT clock used- during normal operation, while the second phandle is the Wake-on-LAN clock.-- clock-names: When provided, names of the functional clock phandles, first- name should be "sw_sysport" and second should be "sw_sysportwol".--Example:-ethernet@f04a0000 {- compatible = "brcm,systemport-v1.00";- reg = <0xf04a0000 0x4650>;- local-mac-address = [ 00 11 22 33 44 55 ];- fixed-link = <0 1 1000 0 0>;- phy-mode = "gmii";- interrupts = <0x0 0x16 0x0>,- <0x0 0x17 0x0>;-};
@@ -1,62 +0,0 @@-Properties for an MDIO bus multiplexer found in Broadcom iProc based SoCs.--This MDIO bus multiplexer defines buses that could be internal as well as-external to SoCs and could accept MDIO transaction compatible to C-22 or-C-45 Clause. When child bus is selected, one needs to select these two-properties as well to generate desired MDIO transaction on appropriate bus.--Required properties in addition to the generic multiplexer properties:--MDIO multiplexer node:-- compatible: brcm,mdio-mux-iproc.--Every non-ethernet PHY requires a compatible so that it could be probed based-on this compatible string.--Optional properties:-- clocks: phandle of the core clock which drives the mdio block.--Additional information regarding generic multiplexer properties can be found-at- Documentation/devicetree/bindings/net/mdio-mux.yaml---for example:- mdio_mux_iproc: mdio-mux@66020000 {- compatible = "brcm,mdio-mux-iproc";- reg = <0x66020000 0x250>;- #address-cells = <1>;- #size-cells = <0>;-- mdio@0 {- reg = <0x0>;- #address-cells = <1>;- #size-cells = <0>;-- pci_phy0: pci-phy@0 {- compatible = "brcm,ns2-pcie-phy";- reg = <0x0>;- #phy-cells = <0>;- };- };-- mdio@7 {- reg = <0x7>;- #address-cells = <1>;- #size-cells = <0>;-- pci_phy1: pci-phy@0 {- compatible = "brcm,ns2-pcie-phy";- reg = <0x0>;- #phy-cells = <0>;- };- };- mdio@10 {- reg = <0x10>;- #address-cells = <1>;- #size-cells = <0>;-- gphy0: eth-phy@10 {- reg = <0x10>;- };- };- };
@@ -0,0 +1,80 @@+# SPDX-License-Identifier: GPL-2.0+%YAML1.2+---+$id:http://devicetree.org/schemas/net/brcm,mdio-mux-iproc.yaml#+$schema:http://devicetree.org/meta-schemas/core.yaml#++title:MDIO bus multiplexer found in Broadcom iProc based SoCs.++maintainers:+-Florian Fainelli <f.fainelli@gmail.com>++description:+This MDIO bus multiplexer defines buses that could be internal as well as+external to SoCs and could accept MDIO transaction compatible to C-22 or+C-45 Clause. When child bus is selected, one needs to select these two+properties as well to generate desired MDIO transaction on appropriate bus.++allOf:+-$ref:/schemas/net/mdio-mux.yaml#++properties:+compatible:+const:brcm,mdio-mux-iproc++reg:+maxItems:1++clocks:+maxItems:1+description:core clock driving the MDIO block+++required:+-compatible+-reg++unevaluatedProperties:false++examples:+-|+mdio_mux_iproc:mdio-mux@66020000 {+compatible = "brcm,mdio-mux-iproc";+reg = <0x66020000 0x250>;+#address-cells = <1>;+#size-cells = <0>;++mdio@0 {+reg = <0x0>;+#address-cells = <1>;+#size-cells = <0>;++pci_phy0:pci-phy@0 {+compatible = "brcm,ns2-pcie-phy";+reg = <0x0>;+#phy-cells = <0>;+};+};++mdio@7 {+reg = <0x7>;+#address-cells = <1>;+#size-cells = <0>;++pci_phy1:pci-phy@0 {+compatible = "brcm,ns2-pcie-phy";+reg = <0x0>;+#phy-cells = <0>;+};+};++mdio@10 {+reg = <0x10>;+#address-cells = <1>;+#size-cells = <0>;++gphy0:eth-phy@10 {+reg = <0x10>;+};+};+};
From: Rob Herring <robh@kernel.org> Date: 2021-12-01 14:40:10
On Tue, 30 Nov 2021 20:12:25 -0800, Florian Fainelli wrote:
Convert the GENET binding to YAML, leveraging brcm,unimac-mdio.yaml and
the standard ethernet-controller.yaml files.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../devicetree/bindings/net/brcm,bcmgenet.txt | 125 ---------------
.../bindings/net/brcm,bcmgenet.yaml | 146 ++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 147 insertions(+), 126 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/net/brcm,bcmgenet.txt
create mode 100644 Documentation/devicetree/bindings/net/brcm,bcmgenet.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,bcmgenet.yaml: properties:interrupts: {'minItems': 2, 'maxItems': 3, 'items': [{'description': 'general purpose interrupt line'}, {'description': 'RX and TX rings interrupt line'}, {'description': 'Wake-on-LAN interrupt line'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,bcmgenet.yaml: properties:clocks: {'minItems': 1, 'maxItems': 3, 'items': [{'description': 'main clock'}, {'description': 'EEE clock'}, {'description': 'Wake-on-LAN clock'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,bcmgenet.yaml: properties:clock-names: {'minItems': 1, 'maxItems': 3, 'items': [{'const': 'enet'}, {'const': 'enet-eee'}, {'const': 'enet-wol'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,bcmgenet.yaml: ignoring, error in schema: properties: interrupts
warning: no schema found in file: ./Documentation/devicetree/bindings/net/brcm,bcmgenet.yaml
Documentation/devicetree/bindings/net/brcm,bcmgenet.example.dt.yaml:0:0: /example-0/ethernet@f0b60000: failed to match any schema with compatible: ['brcm,genet-v4']
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,bcmgenet.example.dt.yaml: mdio@e14: 'reg-names' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
Documentation/devicetree/bindings/net/brcm,bcmgenet.example.dt.yaml:0:0: /example-1/ethernet@f0b80000: failed to match any schema with compatible: ['brcm,genet-v4']
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,bcmgenet.example.dt.yaml: mdio@e14: 'reg-names' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
Documentation/devicetree/bindings/net/brcm,bcmgenet.example.dt.yaml:0:0: /example-2/ethernet@f0ba0000: failed to match any schema with compatible: ['brcm,genet-v4']
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,bcmgenet.example.dt.yaml: mdio@e14: 'reg-names' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1561997
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
From: Rob Herring <robh@kernel.org> Date: 2021-12-01 14:40:16
On Tue, 30 Nov 2021 20:12:24 -0800, Florian Fainelli wrote:
MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores
and will be needed in order to convert GENET to YAML in subsequent
changes.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
1 file changed, 1 insertion(+)
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1561996
ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml
ethernet@17020000: phy-handle: [[36], [37]] is too long
arch/arm64/boot/dts/apm/apm-mustang.dt.yaml
ethernet@30000: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dt.yaml
arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dt.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.example.dt.yaml:0:0: /example-0/mdio-mux@66020000/mdio@0/pci-phy@0: failed to match any schema with compatible: ['brcm,ns2-pcie-phy']
Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.example.dt.yaml:0:0: /example-0/mdio-mux@66020000/mdio@7/pci-phy@0: failed to match any schema with compatible: ['brcm,ns2-pcie-phy']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1562000
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,systemport.yaml: properties:interrupts: {'minItems': 2, 'maxItems': 3, 'items': [{'description': 'interrupt line for RX queues'}, {'description': 'interrupt line for TX queues'}, {'description': 'interrupt line for Wake-on-LAN'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,systemport.yaml: ignoring, error in schema: properties: interrupts
warning: no schema found in file: ./Documentation/devicetree/bindings/net/brcm,systemport.yaml
Documentation/devicetree/bindings/net/brcm,systemport.example.dt.yaml:0:0: /example-0/ethernet@f04a0000: failed to match any schema with compatible: ['brcm,systemport-v1.00']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1561999
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
On Tue, 30 Nov 2021 20:12:24 -0800, Florian Fainelli wrote:
quoted
MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores
and will be needed in order to convert GENET to YAML in subsequent
changes.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
1 file changed, 1 insertion(+)
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1561996
ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml
ethernet@17020000: phy-handle: [[36], [37]] is too long
arch/arm64/boot/dts/apm/apm-mustang.dt.yaml
ethernet@30000: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dt.yaml
arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dt.yaml
These are all pre-existing warnings, but we should be documenting speed
2500 in ethernet-controller.yaml, so I will add a patch towards that end.
The one for apm-mustand.dts however I am not sure how to best resolve
since it looks like there was an intention to provide two Ethernet PHYs
and presumably have the firmware prune the one that is not in use. I
don't even know if that platform is supported mainline anymore.
--
Florian
From: Rob Herring <robh@kernel.org> Date: 2021-12-01 18:29:14
On Wed, Dec 1, 2021 at 11:15 AM Florian Fainelli [off-list ref] wrote:
On 12/1/21 6:33 AM, Rob Herring wrote:
quoted
On Tue, 30 Nov 2021 20:12:24 -0800, Florian Fainelli wrote:
quoted
MoCA (Multimedia over Coaxial) is used by the internal GENET/MOCA cores
and will be needed in order to convert GENET to YAML in subsequent
changes.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
1 file changed, 1 insertion(+)
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1561996
ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml
ethernet@17020000: phy-handle: [[36], [37]] is too long
arch/arm64/boot/dts/apm/apm-mustang.dt.yaml
ethernet@30000: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dt.yaml
arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dt.yaml
These are all pre-existing warnings, but we should be documenting speed
2500 in ethernet-controller.yaml, so I will add a patch towards that end.
Thanks.
The one for apm-mustand.dts however I am not sure how to best resolve
since it looks like there was an intention to provide two Ethernet PHYs
and presumably have the firmware prune the one that is not in use. I
don't even know if that platform is supported mainline anymore.
Unfortunately it is, barely. I just fixed a breakage I caused 2 years
ago and just now noticed. I would not worry about it for now.
Rob
@@ -1,62 +0,0 @@-Properties for an MDIO bus multiplexer found in Broadcom iProc based SoCs.--This MDIO bus multiplexer defines buses that could be internal as well as-external to SoCs and could accept MDIO transaction compatible to C-22 or-C-45 Clause. When child bus is selected, one needs to select these two-properties as well to generate desired MDIO transaction on appropriate bus.--Required properties in addition to the generic multiplexer properties:--MDIO multiplexer node:-- compatible: brcm,mdio-mux-iproc.--Every non-ethernet PHY requires a compatible so that it could be probed based-on this compatible string.--Optional properties:-- clocks: phandle of the core clock which drives the mdio block.--Additional information regarding generic multiplexer properties can be found-at- Documentation/devicetree/bindings/net/mdio-mux.yaml---for example:- mdio_mux_iproc: mdio-mux@66020000 {- compatible = "brcm,mdio-mux-iproc";- reg = <0x66020000 0x250>;- #address-cells = <1>;- #size-cells = <0>;-- mdio@0 {- reg = <0x0>;- #address-cells = <1>;- #size-cells = <0>;-- pci_phy0: pci-phy@0 {- compatible = "brcm,ns2-pcie-phy";- reg = <0x0>;- #phy-cells = <0>;- };- };-- mdio@7 {- reg = <0x7>;- #address-cells = <1>;- #size-cells = <0>;-- pci_phy1: pci-phy@0 {- compatible = "brcm,ns2-pcie-phy";- reg = <0x0>;- #phy-cells = <0>;- };- };- mdio@10 {- reg = <0x10>;- #address-cells = <1>;- #size-cells = <0>;-- gphy0: eth-phy@10 {- reg = <0x10>;- };- };- };
All Broadcom authors on the original. Please add BSD-2-Clause.
Sure, please review v2 and let me know if there are other changes that
should be done, v2 was sent before you had a chance to reply to this one.
--
Florian