[PATCH] Fix Comment of ETH_P_802_3_MIN

Subsystems: networking drivers, the rest

STALE1768d

2 messages, 2 authors, 2021-12-02 · open the first message on its own page

[PATCH] Fix Comment of ETH_P_802_3_MIN

From: <hidden>
Date: 2021-12-01 02:57:24

From: Xiayu Zhang <redacted>

The description of ETH_P_802_3_MIN is misleading.
The value of EthernetType in Ethernet II frame is more than 0x0600,
the value of Length in 802.3 frame is less than 0x0600.

Signed-off-by: Xiayu Zhang <redacted>
---
 include/uapi/linux/if_ether.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h
index 5da4ee234e0b..c0c2f3ed5729 100644
--- a/include/uapi/linux/if_ether.h
+++ b/include/uapi/linux/if_ether.h
@@ -117,7 +117,7 @@
 #define ETH_P_IFE	0xED3E		/* ForCES inter-FE LFB type */
 #define ETH_P_AF_IUCV   0xFBFB		/* IBM af_iucv [ NOT AN OFFICIALLY REGISTERED ID ] */
 
-#define ETH_P_802_3_MIN	0x0600		/* If the value in the ethernet type is less than this value
+#define ETH_P_802_3_MIN	0x0600		/* If the value in the ethernet type is more than this value
 					 * then the frame is Ethernet II. Else it is 802.3 */
 
 /*
-- 
2.17.0

Re: [PATCH] Fix Comment of ETH_P_802_3_MIN

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-02 12:20:43

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Wed, 1 Dec 2021 10:57:13 +0800 you wrote:
From: Xiayu Zhang <redacted>

The description of ETH_P_802_3_MIN is misleading.
The value of EthernetType in Ethernet II frame is more than 0x0600,
the value of Length in 802.3 frame is less than 0x0600.

Signed-off-by: Xiayu Zhang <redacted>

[...]
Here is the summary with links:
  - Fix Comment of ETH_P_802_3_MIN
    https://git.kernel.org/netdev/net/c/72f6a45202f2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help