# Re: \[PATCH\] selftests/net: udpgso\_bench\_tx: fix dst ip argument

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2021-12-30 02:25:20 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/12/11219686
- Thread: https://ratatoskr.run/netdev/2021/12/11219651/t.md

```text
On Wed, 29 Dec 2021 09:16:37 -0500 Willem de Bruijn wrote:
> On Wed, Dec 29, 2021 at 5:58 AM Jianguo Wu [ref] wrote:
> >
> > From: wujianguo <redacted>
> >
> > udpgso_bench_tx call setup_sockaddr() for dest address before
> > parsing all arguments, if we specify "-p ${dst_port}" after "-D ${dst_ip}",
> > then ${dst_port} will be ignored, and using default cfg_port 8000.
> >
> > This will cause test case "multiple GRO socks" failed in udpgro.sh.
> >
> > Setup sockaddr after after parsing all arguments.

s/after after/after/

> >
> > Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> > Signed-off-by: Jianguo Wu <redacted>  
> 
> Reviewed-by: Willem de Bruijn <willemb@google.com>
> 
> The udpgso_bench_tx equivalent to commit d336509cb9d0 ("selftests/net:
> udpgso_bench_rx: fix port argument"). Thanks.

Applied, thanks!
```