4 messages, 2 authors, 2022-01-05 · open the first message on its own page
From: Guangbin Huang <hidden>
Date: 2021-12-20 08:36:47
Add support for "ethtool -G/g <dev>" to set/get rx buf len and support for "ethtool --set/get-tunable <dev>" to set/get tx copybreak buf size. Hao Chen (2): ethtool: netlink: add support to set/get rx buf len ethtool: netlink: add support to get/set tx copybreak buf size ethtool.c | 9 +++++++++ netlink/rings.c | 7 +++++++ 2 files changed, 16 insertions(+) -- 2.33.0
From: Guangbin Huang <hidden>
Date: 2021-12-20 08:36:48
From: Hao Chen <redacted> Add support for "ethtool -G <dev> rx-buf-len xxx" and "ethtool -g <dev>" to set/get rx-buf-len. Signed-off-by: Hao Chen <redacted> Signed-off-by: Guangbin Huang <redacted> --- ethtool.c | 1 + netlink/rings.c | 7 +++++++ 2 files changed, 8 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 55dac51..0dc3559 100644
--- a/ethtool.c
+++ b/ethtool.c@@ -5724,6 +5724,7 @@ static const struct option args[] = { " [ rx-mini N ]\n" " [ rx-jumbo N ]\n" " [ tx N ]\n" + " [ rx-buf-len N]\n" }, { .opts = "-k|--show-features|--show-offload",
diff --git a/netlink/rings.c b/netlink/rings.c
index b8c458f..119178e 100644
--- a/netlink/rings.c
+++ b/netlink/rings.c@@ -46,6 +46,7 @@ int rings_reply_cb(const struct nlmsghdr *nlhdr, void *data) show_u32(tb[ETHTOOL_A_RINGS_RX_MINI], "RX Mini:\t"); show_u32(tb[ETHTOOL_A_RINGS_RX_JUMBO], "RX Jumbo:\t"); show_u32(tb[ETHTOOL_A_RINGS_TX], "TX:\t\t"); + show_u32(tb[ETHTOOL_A_RINGS_RX_BUF_LEN], "RX Buf Len:\t\t"); return MNL_CB_OK; }
@@ -98,6 +99,12 @@ static const struct param_parser sring_params[] = { .handler = nl_parse_direct_u32, .min_argc = 1, }, + { + .arg = "rx-buf-len", + .type = ETHTOOL_A_RINGS_RX_BUF_LEN, + .handler = nl_parse_direct_u32, + .min_argc = 1, + }, {} };
--
2.33.0
From: Guangbin Huang <hidden>
Date: 2021-12-20 08:36:50
From: Hao Chen <redacted> Add support for "ethtool --set-tunable <dev> tx-buf-size xxx" and "ethtool --get-tunable <dev> tx-buf-size" to set/get tx copybreak buf size. Signed-off-by: Hao Chen <redacted> Signed-off-by: Guangbin Huang <redacted> --- ethtool.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 0dc3559..5d718a2 100644
--- a/ethtool.c
+++ b/ethtool.c@@ -5009,6 +5009,7 @@ tunable_strings[__ETHTOOL_TUNABLE_COUNT][ETH_GSTRING_LEN] = { [ETHTOOL_ID_UNSPEC] = "Unspec", [ETHTOOL_RX_COPYBREAK] = "rx-copybreak", [ETHTOOL_TX_COPYBREAK] = "tx-copybreak", + [ETHTOOL_TX_COPYBREAK_BUF_SIZE] = "tx-buf-size", [ETHTOOL_PFC_PREVENTION_TOUT] = "pfc-prevention-tout", };
@@ -5048,6 +5049,11 @@ static struct ethtool_tunable_info tunables_info[] = { .size = sizeof(u16), .type = CMDL_U16, }, + { .t_id = ETHTOOL_TX_COPYBREAK_BUF_SIZE, + .t_type_id = ETHTOOL_TUNABLE_U32, + .size = sizeof(u32), + .type = CMDL_U32, + }, }; #define TUNABLES_INFO_SIZE ARRAY_SIZE(tunables_info)
@@ -5961,6 +5967,7 @@ static const struct option args[] = { .help = "Get tunable", .xhelp = " [ rx-copybreak ]\n" " [ tx-copybreak ]\n" + " [ tx-buf-size ]\n" " [ pfc-precention-tout ]\n" }, {
@@ -5969,6 +5976,7 @@ static const struct option args[] = { .help = "Set tunable", .xhelp = " [ rx-copybreak N]\n" " [ tx-copybreak N]\n" + " [ tx-buf-size N]\n" " [ pfc-precention-tout N]\n" }, {
--
2.33.0
From: Michal Kubecek <hidden>
Date: 2022-01-05 08:45:23
On Mon, Dec 20, 2021 at 04:31:53PM +0800, Guangbin Huang wrote:
Add support for "ethtool -G/g <dev>" to set/get rx buf len and support for "ethtool --set/get-tunable <dev>" to set/get tx copybreak buf size.
Applied both patches to next branch (with minor subject adjustment so that the bot may not recognize). Next time, please do not forget to update also the man page (ethtool.8.in file). Michal
Hao Chen (2): ethtool: netlink: add support to set/get rx buf len ethtool: netlink: add support to get/set tx copybreak buf size ethtool.c | 9 +++++++++ netlink/rings.c | 7 +++++++ 2 files changed, 16 insertions(+) -- 2.33.0