[PATCH net-next] net: mtk_eth_soc: delete an unneeded variable

Subsystems: mediatek ethernet driver, networking drivers, the rest

STALE1766d LANDED

Landed in mainline as ddfbe18da55c on 2021-12-18.

2 messages, 2 authors, 2021-12-18 · open the first message on its own page

[PATCH net-next] net: mtk_eth_soc: delete an unneeded variable

From: Dan Carpenter <hidden>
Date: 2021-12-17 07:08:43

There is already an "int err" declared at the start of the function so
re-use that instead of declaring a shadow err variable.

Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index a068cf5c970f..bcb91b01e69f 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2211,7 +2211,6 @@ static int mtk_open(struct net_device *dev)
 	/* we run 2 netdevs on the same dma ring so we only bring it up once */
 	if (!refcount_read(&eth->dma_refcnt)) {
 		u32 gdm_config = MTK_GDMA_TO_PDMA;
-		int err;
 
 		err = mtk_start_dma(eth);
 		if (err)
-- 
2.20.1

Re: [PATCH net-next] net: mtk_eth_soc: delete an unneeded variable

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-18 03:30:24

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Fri, 17 Dec 2021 10:07:35 +0300 you wrote:
There is already an "int err" declared at the start of the function so
re-use that instead of declaring a shadow err variable.

Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 -
 1 file changed, 1 deletion(-)
Here is the summary with links:
  - [net-next] net: mtk_eth_soc: delete an unneeded variable
    https://git.kernel.org/netdev/net-next/c/ddfbe18da55c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help