[PATCH net] selftest/net/forwarding: declare NETIFS p9 p10

Subsystems: kernel selftest framework, networking [general], networking [ipv4/ipv6], the rest

STALE1760d

3 messages, 3 authors, 2021-12-13 · open the first message on its own page

[PATCH net] selftest/net/forwarding: declare NETIFS p9 p10

From: Hangbin Liu <hidden>
Date: 2021-12-13 08:36:37

The resent GRE selftests defined NUM_NETIFS=10. If the users copy
forwarding.config.sample to forwarding.config directly, they will get
error "Command line is not complete" when run the GRE tests, because
create_netif_veth() failed with no interface name defined.

Fix it by extending the NETIFS with p9 and p10.

Fixes: 2800f2485417 ("selftests: forwarding: Test multipath hashing on inner IP pkts for GRE tunnel")
Signed-off-by: Hangbin Liu <redacted>
---
 tools/testing/selftests/net/forwarding/forwarding.config.sample | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/forwarding/forwarding.config.sample b/tools/testing/selftests/net/forwarding/forwarding.config.sample
index bf17e485684f..b0980a2efa31 100644
--- a/tools/testing/selftests/net/forwarding/forwarding.config.sample
+++ b/tools/testing/selftests/net/forwarding/forwarding.config.sample
@@ -13,6 +13,8 @@ NETIFS[p5]=veth4
 NETIFS[p6]=veth5
 NETIFS[p7]=veth6
 NETIFS[p8]=veth7
+NETIFS[p9]=veth8
+NETIFS[p10]=veth9
 
 # Port that does not have a cable connected.
 NETIF_NO_CABLE=eth8
-- 
2.31.1

Re: [PATCH net] selftest/net/forwarding: declare NETIFS p9 p10

From: Ido Schimmel <hidden>
Date: 2021-12-13 13:25:52

On Mon, Dec 13, 2021 at 04:36:00PM +0800, Hangbin Liu wrote:
The resent GRE selftests defined NUM_NETIFS=10. If the users copy
s/resent/recent/
forwarding.config.sample to forwarding.config directly, they will get
error "Command line is not complete" when run the GRE tests, because
create_netif_veth() failed with no interface name defined.

Fix it by extending the NETIFS with p9 and p10.

Fixes: 2800f2485417 ("selftests: forwarding: Test multipath hashing on inner IP pkts for GRE tunnel")
Signed-off-by: Hangbin Liu <redacted>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Re: [PATCH net] selftest/net/forwarding: declare NETIFS p9 p10

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-13 15:00:12

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Mon, 13 Dec 2021 16:36:00 +0800 you wrote:
The resent GRE selftests defined NUM_NETIFS=10. If the users copy
forwarding.config.sample to forwarding.config directly, they will get
error "Command line is not complete" when run the GRE tests, because
create_netif_veth() failed with no interface name defined.

Fix it by extending the NETIFS with p9 and p10.

[...]
Here is the summary with links:
  - [net] selftest/net/forwarding: declare NETIFS p9 p10
    https://git.kernel.org/netdev/net/c/71da1aec2152

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help