[PATCH net-next] net: mvneta: mark as a legacy_pre_march2020 driver

Subsystems: marvell mvneta ethernet driver, networking drivers, the rest

STALE1759d

2 messages, 2 authors, 2021-12-13 · open the first message on its own page

[PATCH net-next] net: mvneta: mark as a legacy_pre_march2020 driver

From: Russell King (Oracle) <hidden>
Date: 2021-12-12 13:01:25

mvneta provides mac_an_restart and mac_pcs_get_state methods, so needs
to be marked as a legacy driver. Marek spotted that mvneta had stopped
working in 2500base-X mode - thanks for reporting.

Reported-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Russell King (Oracle) <redacted>
---
 drivers/net/ethernet/marvell/mvneta.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index ce810fc3c1a2..e3c5d64ba340 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -5275,6 +5275,7 @@ static int mvneta_probe(struct platform_device *pdev)
 
 	pp->phylink_config.dev = &dev->dev;
 	pp->phylink_config.type = PHYLINK_NETDEV;
+	pp->phylink_config.legacy_pre_march2020 = true;
 	pp->phylink_config.mac_capabilities = MAC_SYM_PAUSE | MAC_10 |
 		MAC_100 | MAC_1000FD | MAC_2500FD;
 
-- 
2.30.2

Re: [PATCH net-next] net: mvneta: mark as a legacy_pre_march2020 driver

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-13 14:20:39

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller [off-list ref]:

On Sun, 12 Dec 2021 13:01:21 +0000 you wrote:
mvneta provides mac_an_restart and mac_pcs_get_state methods, so needs
to be marked as a legacy driver. Marek spotted that mvneta had stopped
working in 2500base-X mode - thanks for reporting.

Reported-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Russell King (Oracle) <redacted>

[...]
Here is the summary with links:
  - [net-next] net: mvneta: mark as a legacy_pre_march2020 driver
    https://git.kernel.org/netdev/net-next/c/2106be4fdf32

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help