# Re: \[PATCH v6 net-next 04/12\] flow\_offload: return EOPNOTSUPP for the unsupported mpls action type

- From: Roi Dayan \<hidden\>
- Date: 2021-12-12 12:42:10 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/12/11218672
- Thread: https://ratatoskr.run/netdev/2021/12/11218438/t.md

```text


On 2021-12-09 11:27 AM, Simon Horman wrote:
> From: Baowen Zheng <redacted>
>
> We need to return EOPNOTSUPP for the unsupported mpls action type when
> setup the flow action.
>
> In the original implement, we will return 0 for the unsupported mpls
> action type, actually we do not setup it and the following actions
> to the flow action entry.
>
> Signed-off-by: Baowen Zheng <redacted>
> Signed-off-by: Simon Horman <redacted>
> ---
>   net/sched/cls_api.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index d9d6ff0bf361..7a680cae0bae 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -3687,6 +3687,7 @@ int tc_setup_flow_action(struct flow_action *flow_action,
>   				entry->mpls_mangle.ttl = tcf_mpls_ttl(act);
>   				break;
>   			default:
> +				err = -EOPNOTSUPP;
>   				goto err_out_locked;
>   			}
>   		} else if (is_tcf_skbedit_ptype(act)) {

should we have this commit in net branch with a fixes line
so it will be taken also to stable kernels?

6749d5901698 net: sched: include mpls actions in hardware intermediate representation

```