# Re: \[PATCH v2 4/7\] fs/binfmt\_elf: replace open-coded string copy with get\_task\_comm

- From: Yafang Shao \<hidden\>
- Date: 2021-11-30 15:54:09 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/11/219132
- Thread: https://ratatoskr.run/netdev/2021/11/218444/t.md

```text
On Tue, Nov 30, 2021 at 10:22 PM Steven Rostedt [ref] wrote:
>
> On Tue, 30 Nov 2021 11:01:27 +0800
> Yafang Shao [ref] wrote:
>
> > There are three options,
> > - option 1
> >   comment on all the hard-coded 16 to explain why it is hard-coded
> > - option 2
> >   replace the hard-coded 16 that can be replaced and comment on the
> > others which can't be replaced.
> > - option 3
> >    replace the hard-coded 16 that can be replaced and specifically
> > define TASK_COMM_LEN_16 in other files which can't include
> > linux/sched.h.
> >
> > Which one do you prefer ?
> >
>
> Option 3. Since TASK_COMM_LEN_16 is, by it's name, already hard coded to
> 16, it doesn't really matter if you define it in more than one location.
>
> Or we could define it in another header that include/sched.h can include.
>
> The idea of having TASK_COMM_LEN_16 is to easily grep for it, and also know
> exactly what it is used for when people see it being used.
>

I will send a separate patch (or patchset) to replace all the old
hard-coded 16 with TASK_COMM_LEN_16 based on the -mm tree.

--
Thanks
Yafang
```
