[PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

Subsystems: ethernet phy library, networking drivers, the rest

STALE1721d LANDED

Landed in mainline as 8057cbb8335c on 2021-12-02.

3 messages, 3 authors, 2021-12-02 · open the first message on its own page

[PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

From: Tianchen Ding <hidden>
Date: 2021-11-30 11:02:27

There's build error while CONFIG_REGMAP_MMIO is not set
and CONFIG_MDIO_MSCC_MIIM=m.

ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/net/mdio/mdio-mscc-miim.ko] undefined!

Add the depend of REGMAP_MMIO to fix it.

Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
Signed-off-by: Tianchen Ding <redacted>
---
 drivers/net/mdio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig
index 6da1fcb25847..bfa16826a6e1 100644
--- a/drivers/net/mdio/Kconfig
+++ b/drivers/net/mdio/Kconfig
@@ -141,7 +141,7 @@ config MDIO_MVUSB
 
 config MDIO_MSCC_MIIM
 	tristate "Microsemi MIIM interface support"
-	depends on HAS_IOMEM
+	depends on HAS_IOMEM && REGMAP_MMIO
 	select MDIO_DEVRES
 	help
 	  This driver supports the MIIM (MDIO) interface found in the network
-- 
2.27.0

Re: [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-11-30 18:13:31

On Tue, Nov 30, 2021 at 07:02:09PM +0800, Tianchen Ding wrote:
There's build error while CONFIG_REGMAP_MMIO is not set
and CONFIG_MDIO_MSCC_MIIM=m.

ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/net/mdio/mdio-mscc-miim.ko] undefined!

Add the depend of REGMAP_MMIO to fix it.

Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
Signed-off-by: Tianchen Ding <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-12-02 03:01:06

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Tue, 30 Nov 2021 19:02:09 +0800 you wrote:
There's build error while CONFIG_REGMAP_MMIO is not set
and CONFIG_MDIO_MSCC_MIIM=m.

ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/net/mdio/mdio-mscc-miim.ko] undefined!

Add the depend of REGMAP_MMIO to fix it.

[...]
Here is the summary with links:
  - net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM
    https://git.kernel.org/netdev/net-next/c/8057cbb8335c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help