[PATCH -next] mctp: test: use kfree_skb() instead of kfree()

Subsystems: management component transport protocol (mctp), networking [general], the rest

STALE1712d

2 messages, 2 authors, 2021-11-30 · open the first message on its own page

[PATCH -next] mctp: test: use kfree_skb() instead of kfree()

From: Yang Yingliang <hidden>
Date: 2021-11-30 03:04:25

Use kfree_skb() instead of kfree() to free sk_buff.

Signed-off-by: Yang Yingliang <redacted>
---
 net/mctp/test/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mctp/test/utils.c b/net/mctp/test/utils.c
index cc6b8803aa9d..7b7918702592 100644
--- a/net/mctp/test/utils.c
+++ b/net/mctp/test/utils.c
@@ -12,7 +12,7 @@
 static netdev_tx_t mctp_test_dev_tx(struct sk_buff *skb,
 				    struct net_device *ndev)
 {
-	kfree(skb);
+	kfree_skb(skb);
 	return NETDEV_TX_OK;
 }
 
-- 
2.25.1

Re: [PATCH -next] mctp: test: use kfree_skb() instead of kfree()

From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2021-11-30 03:27:41

Hi Yang,
Use kfree_skb() instead of kfree() to free sk_buff.
Thanks for the patch! We do already have this queued in -net though:

 https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=d85195654470

(which should percolate to net-next in due course too).

Cheers,


Jeremy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help