[PATCH] ice: Slightly simply ice_find_free_recp_res_idx

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE1686d

2 messages, 2 authors, 2022-01-06 · open the first message on its own page

[PATCH] ice: Slightly simply ice_find_free_recp_res_idx

From: Christophe JAILLET <hidden>
Date: 2021-11-17 21:21:28

The 'possible_idx' bitmap is set just after it is zeroed, so we can save
the first step.

The 'free_idx' bitmap is used only at the end of the function as the
result of a bitmap xor operation. So there is no need to explicitly
zero it before.

So, slightly simply the code and remove 2 useless 'bitmap_zero()' call

Signed-off-by: Christophe JAILLET <redacted>
---
I don't think it will make any differences in RL. ICE_MAX_FV_WORDS is
just 48 (bits), so 1 or 2 longs
---
 drivers/net/ethernet/intel/ice/ice_switch.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 793f4a9fc2cd..78bfb9fd318d 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -4071,10 +4071,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
 	DECLARE_BITMAP(used_idx, ICE_MAX_FV_WORDS);
 	u16 bit;
 
-	bitmap_zero(possible_idx, ICE_MAX_FV_WORDS);
 	bitmap_zero(recipes, ICE_MAX_NUM_RECIPES);
 	bitmap_zero(used_idx, ICE_MAX_FV_WORDS);
-	bitmap_zero(free_idx, ICE_MAX_FV_WORDS);
 
 	bitmap_set(possible_idx, 0, ICE_MAX_FV_WORDS);
 
-- 
2.30.2

RE: [Intel-wired-lan] [PATCH] ice: Slightly simply ice_find_free_recp_res_idx

From: Penigalapati, Sandeep <hidden>
Date: 2022-01-06 04:47:05

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Christophe JAILLET
Sent: Thursday, November 18, 2021 2:51 AM
To: Brandeburg, Jesse <redacted>; Nguyen, Anthony L
[off-list ref]; davem@davemloft.net; kuba@kernel.org
Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe
JAILLET [off-list ref]; intel-wired-lan@lists.osuosl.org;
linux-kernel@vger.kernel.org
Subject: [Intel-wired-lan] [PATCH] ice: Slightly simply
ice_find_free_recp_res_idx

The 'possible_idx' bitmap is set just after it is zeroed, so we can save the first
step.

The 'free_idx' bitmap is used only at the end of the function as the result of a
bitmap xor operation. So there is no need to explicitly zero it before.

So, slightly simply the code and remove 2 useless 'bitmap_zero()' call

Signed-off-by: Christophe JAILLET <redacted>
---
I don't think it will make any differences in RL. ICE_MAX_FV_WORDS is just 48
(bits), so 1 or 2 longs
---
drivers/net/ethernet/intel/ice/ice_switch.c | 2 --
1 file changed, 2 deletions(-)
Tested-by: Sandeep Penigalapati <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help