Re: [EXTERNAL] Re: [PATCH net-next] net: phy: add support for TI DP83561-SP phy

On Tue, Nov 16, 2021 at 03:58:27PM +0000, Modi, Geet wrote:

Hello Andrew,

 

We being Texas Instruments are conservative and don't promote meaningless
marketing as well. Please note DP83561-SP is a Radiation Hardened Space Grade
Gigabit PHY. It has been tested for Single Event Latch up upto 121 MeV, the
critical reliability parameter Space Designs look for.

That statement i have no problems with, it is clearly factual.

The dp83561-sp is a high reliability gigabit ethernet PHY designed

is clearly Marketing, who would design a low reliability gigabit
ethernet PHY? It is meaningless.

So please use your text from above in the commit message, it nicely
describes what this PHY is in engineering terms.

   Andrew

Thanks Andrew. 

Hari, please update the commit message and re-submit.


Regards,
Geet

On 11/16/21, 8:15 AM, "Andrew Lunn" [off-list ref] wrote:

    On Tue, Nov 16, 2021 at 03:58:27PM +0000, Modi, Geet wrote:
    > Hello Andrew,
    > 
    >  
    > 
    > We being Texas Instruments are conservative and don't promote meaningless
    > marketing as well. Please note DP83561-SP is a Radiation Hardened Space Grade
    > Gigabit PHY. It has been tested for Single Event Latch up upto 121 MeV, the
    > critical reliability parameter Space Designs look for.

    That statement i have no problems with, it is clearly factual.

    > The dp83561-sp is a high reliability gigabit ethernet PHY designed

    is clearly Marketing, who would design a low reliability gigabit
    ethernet PHY? It is meaningless.

    So please use your text from above in the commit message, it nicely
    describes what this PHY is in engineering terms.

       Andrew