[PATCH] amt: add IPV6 Kconfig dependency

Subsystems: networking drivers, the rest

STALE1737d

3 messages, 3 authors, 2021-11-09 · open the first message on its own page

[PATCH] amt: add IPV6 Kconfig dependency

From: Arnd Bergmann <arnd@kernel.org>
Date: 2021-11-08 11:14:24

From: Arnd Bergmann <arnd@arndb.de>

This driver cannot be built-in if IPV6 is a loadable module:

x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'

Add the idiomatic Kconfig dependency that all such modules
have.

Fixes: b9022b53adad ("amt: add control plane of amt interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 034dbd487c33..10506a4b66ef 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -294,6 +294,7 @@ config GTP
 config AMT
 	tristate "Automatic Multicast Tunneling (AMT)"
 	depends on INET && IP_MULTICAST
+	depends on IPV6 || !IPV6
 	select NET_UDP_TUNNEL
 	help
 	  This allows one to create AMT(Automatic Multicast Tunneling)
-- 
2.29.2

Re: [PATCH] amt: add IPV6 Kconfig dependency

From: Taehee Yoo <ap420073@gmail.com>
Date: 2021-11-08 12:39:17

Hi Arnd,

On 11/8/21 8:12 PM, Arnd Bergmann wrote:
quoted hunk
From: Arnd Bergmann <arnd@arndb.de>

This driver cannot be built-in if IPV6 is a loadable module:

x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'

Add the idiomatic Kconfig dependency that all such modules
have.

Fixes: b9022b53adad ("amt: add control plane of amt interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
  drivers/net/Kconfig | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 034dbd487c33..10506a4b66ef 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -294,6 +294,7 @@ config GTP
  config AMT
  	tristate "Automatic Multicast Tunneling (AMT)"
  	depends on INET && IP_MULTICAST
+	depends on IPV6 || !IPV6
  	select NET_UDP_TUNNEL
  	help
  	  This allows one to create AMT(Automatic Multicast Tunneling)
Acked-by: Taehee Yoo <ap420073@gmail.com>

Re: [PATCH] amt: add IPV6 Kconfig dependency

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-09 14:10:14

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Mon,  8 Nov 2021 12:12:24 +0100 you wrote:
From: Arnd Bergmann <arnd@arndb.de>

This driver cannot be built-in if IPV6 is a loadable module:

x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'

[...]
Here is the summary with links:
  - amt: add IPV6 Kconfig dependency
    https://git.kernel.org/netdev/net/c/9758aba8542b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help