# Re: \[PATCH net-next\] devlink: Require devlink lock during device reload

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2021-11-01 23:11:53 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/11/1560164
- Thread: https://ratatoskr.run/netdev/2021/10/1558858/t.md

```text
On Mon, 1 Nov 2021 22:52:19 +0200 Ido Schimmel wrote:
> > >Signed-off-by: Leon Romanovsky <leonro@nvidia.com>  
> > 
> > Looks fine to me.
> > 
> > Reviewed-by: Jiri Pirko <redacted>  
> 
> Traces from mlxsw / netdevsim below:

Thanks a lot for the testing Ido!

Would you mind giving my RFC a spin as well on your syzbot machinery?

Any input on the three discussion points there?

 (1) should we have a "locked" and "unlocked" API or use lock nesting?

 (2) should we expose devlink lock so that drivers can use devlink 
     as a framework for their locking needs?

 (3) should we let drivers take refs on the devlink instance?
```