# Re: \[PATCH\] iwlwifi: pcie: fix constant-conversion warning

- From: Coelho, Luciano \<hidden\>
- Date: 2021-11-01 07:32:27 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/11/1559117
- Thread: https://ratatoskr.run/llvm/2021/10/1558758/t.md

```text
On Mon, 2021-11-01 at 09:29 +0200, Luciano Coelho wrote:
> On Sun, 2021-10-31 at 09:06 +0200, Kalle Valo wrote:
> > Arnd Bergmann [ref] writes:
> > 
> > > From: Arnd Bergmann <arnd@arndb.de>
> > > 
> > > clang points out a potential issue with integer overflow when
> > > the iwl_dev_info_table[] array is empty:
> > > 
> > > drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1344:42: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion]
> > >         for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
> > >                ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> > > 
> > > This is still harmless, as the loop correctly terminates, but adding
> > > an (int) cast makes that clearer to the compiler.
> > > 
> > > Fixes: 3f7320428fa4 ("iwlwifi: pcie: simplify iwl_pci_find_dev_info()")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > Luca, can I take this to wireless-drivers? Ack?
> 
> Yes, please do.
> 
> Thanks.
> 
> Acked-by: Luca Coelho <redacted>

Actually, wouldn't it be simpler to change the declaration of i to be
unsigned int?

--
Luca.


```