[PATCH net] mctp: test: fix skb free in test device tx

Subsystems: management component transport protocol (mctp), networking [general], the rest

STALE1716d

2 messages, 2 authors, 2021-11-29 · open the first message on its own page

[PATCH net] mctp: test: fix skb free in test device tx

From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2021-11-29 02:19:22

In our test device, we're currently freeing skbs in the transmit path
with kfree(), rather than kfree_skb(). This change uses the correct
kfree_skb() instead.

Fixes: ded21b722995 ("mctp: Add test utils")
Reported-by: kernel test robot <redacted>
Reported-by: Dan Carpenter <redacted>
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
---
 net/mctp/test/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mctp/test/utils.c b/net/mctp/test/utils.c
index cc6b8803aa9d..7b7918702592 100644
--- a/net/mctp/test/utils.c
+++ b/net/mctp/test/utils.c
@@ -12,7 +12,7 @@
 static netdev_tx_t mctp_test_dev_tx(struct sk_buff *skb,
 				    struct net_device *ndev)
 {
-	kfree(skb);
+	kfree_skb(skb);
 	return NETDEV_TX_OK;
 }
 
-- 
2.30.2

Re: [PATCH net] mctp: test: fix skb free in test device tx

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-29 13:12:13

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Mon, 29 Nov 2021 10:16:52 +0800 you wrote:
In our test device, we're currently freeing skbs in the transmit path
with kfree(), rather than kfree_skb(). This change uses the correct
kfree_skb() instead.

Fixes: ded21b722995 ("mctp: Add test utils")
Reported-by: kernel test robot <redacted>
Reported-by: Dan Carpenter <redacted>
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>

[...]
Here is the summary with links:
  - [net] mctp: test: fix skb free in test device tx
    https://git.kernel.org/netdev/net/c/d85195654470

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help