[PATCH net-next] tsnep: Fix resource_size cocci warning

Subsystems: networking drivers, the rest

STALE1725d LANDED

Landed in mainline as 1aad9634b94e on 2021-11-25.

2 messages, 2 authors, 2021-11-25 · open the first message on its own page

[PATCH net-next] tsnep: Fix resource_size cocci warning

From: Gerhard Engleder <hidden>
Date: 2021-11-24 20:52:38

From: Gerhard Engleder <redacted>

The following warning is fixed, by removing the unused resource size:

drivers/net/ethernet/engleder/tsnep_main.c:1155:21-24:
WARNING: Suspicious code. resource_size is maybe missing with io

Reported-by: kernel test robot <redacted>
Reported-by: Abaci Robot <redacted>
Signed-off-by: Gerhard Engleder <redacted>
---
 drivers/net/ethernet/engleder/tsnep.h      | 1 -
 drivers/net/ethernet/engleder/tsnep_main.c | 1 -
 2 files changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/engleder/tsnep.h b/drivers/net/ethernet/engleder/tsnep.h
index d19fa175e3d9..23bbece6b7de 100644
--- a/drivers/net/ethernet/engleder/tsnep.h
+++ b/drivers/net/ethernet/engleder/tsnep.h
@@ -125,7 +125,6 @@ struct tsnep_adapter {
 	struct platform_device *pdev;
 	struct device *dmadev;
 	void __iomem *addr;
-	unsigned long size;
 	int irq;
 
 	bool gate_control;
diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
index 8333313dd706..3847368adbeb 100644
--- a/drivers/net/ethernet/engleder/tsnep_main.c
+++ b/drivers/net/ethernet/engleder/tsnep_main.c
@@ -1152,7 +1152,6 @@ static int tsnep_probe(struct platform_device *pdev)
 	adapter->addr = devm_ioremap_resource(&pdev->dev, io);
 	if (IS_ERR(adapter->addr))
 		return PTR_ERR(adapter->addr);
-	adapter->size = io->end - io->start + 1;
 	adapter->irq = platform_get_irq(pdev, 0);
 	netdev->mem_start = io->start;
 	netdev->mem_end = io->end;
-- 
2.20.1

Re: [PATCH net-next] tsnep: Fix resource_size cocci warning

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-25 01:32:14

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Wed, 24 Nov 2021 21:52:25 +0100 you wrote:
From: Gerhard Engleder <redacted>

The following warning is fixed, by removing the unused resource size:

drivers/net/ethernet/engleder/tsnep_main.c:1155:21-24:
WARNING: Suspicious code. resource_size is maybe missing with io

[...]
Here is the summary with links:
  - [net-next] tsnep: Fix resource_size cocci warning
    https://git.kernel.org/netdev/net-next/c/1aad9634b94e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help