[PATCH net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list

Subsystems: networking [general], networking [sockets], the rest

STALE1724d

2 messages, 2 authors, 2021-11-18 · open the first message on its own page

[PATCH net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list

From: Eric Dumazet <hidden>
Date: 2021-11-18 01:57:33

From: Eric Dumazet <edumazet@google.com>

Add missing entries to fix these "make htmldocs" warnings.

./include/linux/skbuff.h:953: warning: Function parameter or member 'll_node' not described in 'sk_buff'
./include/net/sock.h:540: warning: Function parameter or member 'defer_list' not described in 'sock'

Fixes: f35f821935d8 ("tcp: defer skb freeing after socket lock is released")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Stephen Rothwell <redacted>
---
 include/linux/skbuff.h | 1 +
 include/net/sock.h     | 1 +
 2 files changed, 2 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index b8b806512e1615fad2bc9935baba3fff14996012..100fd604fbc9a32180a6f43626249d19bf415c4f 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -627,6 +627,7 @@ typedef unsigned char *sk_buff_data_t;
  *		for retransmit timer
  *	@rbnode: RB tree node, alternative to next/prev for netem/tcp
  *	@list: queue head
+ *	@ll_node: anchor in an llist (eg socket defer_list)
  *	@sk: Socket we are owned by
  *	@ip_defrag_offset: (aka @sk) alternate use of @sk, used in
  *		fragmentation management
diff --git a/include/net/sock.h b/include/net/sock.h
index f09c0c4736c46a18b820949ba3c8ea4e7c6fee57..a79fc772324e5da7b9f489de2e06698695d3e7d7 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -292,6 +292,7 @@ struct bpf_local_storage;
   *	@sk_pacing_shift: scaling factor for TCP Small Queues
   *	@sk_lingertime: %SO_LINGER l_linger setting
   *	@sk_backlog: always used with the per-socket spinlock held
+  *	@defer_list: head of llist storing skbs to be freed
   *	@sk_callback_lock: used with the callbacks in the end of this struct
   *	@sk_error_queue: rarely used
   *	@sk_prot_creator: sk_prot of original sock creator (see ipv6_setsockopt,
-- 
2.34.0.rc1.387.gb447b232ab-goog

Re: [PATCH net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-18 12:10:43

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller [off-list ref]:

On Wed, 17 Nov 2021 17:57:29 -0800 you wrote:
From: Eric Dumazet <edumazet@google.com>

Add missing entries to fix these "make htmldocs" warnings.

./include/linux/skbuff.h:953: warning: Function parameter or member 'll_node' not described in 'sk_buff'
./include/net/sock.h:540: warning: Function parameter or member 'defer_list' not described in 'sock'

[...]
Here is the summary with links:
  - [net-next] tcp: add missing htmldocs for skb->ll_node and sk->defer_list
    https://git.kernel.org/netdev/net-next/c/df6160deb3de

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help