[PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH

Subsystems: the rest

STALE1726d

3 messages, 3 authors, 2021-11-17 · open the first message on its own page

[PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH

From: Maxim Petrov <hidden>
Date: 2021-11-17 18:05:41

Fix the wild bracket in the if clause leading to the error in the condition.

Signed-off-by: Maxim Petrov <redacted>
---
 tc/m_vlan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tc/m_vlan.c b/tc/m_vlan.c
index 221083df..1b2b1d51 100644
--- a/tc/m_vlan.c
+++ b/tc/m_vlan.c

@@ -279,8 +279,8 @@ static int print_vlan(struct action_util *au, FILE *f, struct rtattr *arg)
 				    ETH_ALEN, 0, b1, sizeof(b1));
 			print_string(PRINT_ANY, "dst_mac", " dst_mac %s", b1);
 		}
-		if (tb[TCA_VLAN_PUSH_ETH_SRC &&
-		       RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN]) {
+		if (tb[TCA_VLAN_PUSH_ETH_SRC] &&
+		       RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN) {
 			ll_addr_n2a(RTA_DATA(tb[TCA_VLAN_PUSH_ETH_SRC]),
 				    ETH_ALEN, 0, b1, sizeof(b1));
 			print_string(PRINT_ANY, "src_mac", " src_mac %s", b1);

-- 
2.25.1

Re: [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2021-11-17 19:12:16

On Wed, 17 Nov 2021 21:05:33 +0300
Maxim Petrov [off-list ref] wrote:

quoted hunk

Fix the wild bracket in the if clause leading to the error in the condition.

Signed-off-by: Maxim Petrov <redacted>
---
 tc/m_vlan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tc/m_vlan.c b/tc/m_vlan.c
index 221083df..1b2b1d51 100644
--- a/tc/m_vlan.c
+++ b/tc/m_vlan.c

@@ -279,8 +279,8 @@ static int print_vlan(struct action_util *au, FILE *f, struct rtattr *arg)
 				    ETH_ALEN, 0, b1, sizeof(b1));
 			print_string(PRINT_ANY, "dst_mac", " dst_mac %s", b1);
 		}
-		if (tb[TCA_VLAN_PUSH_ETH_SRC &&
-		       RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN]) {
+		if (tb[TCA_VLAN_PUSH_ETH_SRC] &&
+		       RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN) {
 			ll_addr_n2a(RTA_DATA(tb[TCA_VLAN_PUSH_ETH_SRC]),
 				    ETH_ALEN, 0, b1, sizeof(b1));
 			print_string(PRINT_ANY, "src_mac", " src_mac %s", b1);

Fixes: d61167dd88b4 ("m_vlan: add pop_eth and push_eth actions")

Re: [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-17 22:00:22

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger [off-list ref]:

On Wed, 17 Nov 2021 21:05:33 +0300 you wrote:

Fix the wild bracket in the if clause leading to the error in the condition.

Signed-off-by: Maxim Petrov <redacted>
---
 tc/m_vlan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=0e949725908b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help