[PATCH net] iavf: missing unlocks in iavf_watchdog_task()

This code was re-organized and there some unlocks missing now.

Fixes: 898ef1cb1cb2 ("iavf: Combine init and watchdog state machines")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 847d67e32a54..b97f685a5cf8 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c

@@ -2012,6 +2012,7 @@ static void iavf_watchdog_task(struct work_struct *work)
 		}
 		adapter->aq_required = 0;
 		adapter->current_op = VIRTCHNL_OP_UNKNOWN;
+		mutex_unlock(&adapter->crit_lock);
 		queue_delayed_work(iavf_wq,
 				   &adapter->watchdog_task,
 				   msecs_to_jiffies(10));

@@ -2042,9 +2043,8 @@ static void iavf_watchdog_task(struct work_struct *work)
 			iavf_detect_recover_hung(&adapter->vsi);
 		break;
 	case __IAVF_REMOVE:
-		mutex_unlock(&adapter->crit_lock);
-		return;
 	default:
+		mutex_unlock(&adapter->crit_lock);
 		return;
 	}
 

-- 
2.20.1

Dear Dan,


Thank you for your patch.

For the future, just a nit for the commit message summary. Could you 
make it a statement by adding a verb (in imperative mood) [1].

 > iavf: Add missing unlocks in iavf_watchdog_task()


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/

On Wed, Nov 10, 2021 at 09:53:50AM +0100, Paul Menzel wrote:

Dear Dan,


Thank you for your patch.

For the future, just a nit for the commit message summary. Could you make it
a statement by adding a verb (in imperative mood) [1].

quoted

iavf: Add missing unlocks in iavf_watchdog_task()

Imperative shmeritave.

When subsystems get taken over by fussy bureaucrats then I only send
them bug reports instead of patches.

regards,
dan carpenter

Dear Dan,


Am 10.11.21 um 10:05 schrieb Dan Carpenter:

On Wed, Nov 10, 2021 at 09:53:50AM +0100, Paul Menzel wrote:

quoted

Thank you for your patch.

For the future, just a nit for the commit message summary. Could you make it
a statement by adding a verb (in imperative mood) [1].

quoted

iavf: Add missing unlocks in iavf_watchdog_task()

Imperative shmeritave.

When subsystems get taken over by fussy bureaucrats then I only send
them bug reports instead of patches.

It was just a wish as the standard commit messages follow that format, 
and any verb could be added. It’s not a requirement to my knowledge, and 
I do not have any authority anyway. Sorry about that, and thank you for 
your patches.


Kind regards,

Paul

Yep.  Thanks.  I know.  I'm just trying to discourage those kind of
review comments.

regards,
dan carpenter

Tested-by: Konrad Jankowski <redacted>