[PATCH net-next] gve: fix unmatched u64_stats_update_end()

Subsystems: networking drivers, the rest

STALE1739d

2 messages, 2 authors, 2021-11-10 · open the first message on its own page

[PATCH net-next] gve: fix unmatched u64_stats_update_end()

From: Dan Carpenter <hidden>
Date: 2021-11-10 08:11:33

The u64_stats_update_end() call is supposed to be inside the curly
braces so it pairs with the u64_stats_update_begin().

Fixes: 37149e9374bf ("gve: Implement packet continuation for RX.")
Signed-off-by: Dan Carpenter <redacted>
---
Based on the indenting.  Not tested.

 drivers/net/ethernet/google/gve/gve_rx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
index c8500babbd1d..3d04b5aff331 100644
--- a/drivers/net/ethernet/google/gve/gve_rx.c
+++ b/drivers/net/ethernet/google/gve/gve_rx.c
@@ -500,7 +500,8 @@ static struct sk_buff *gve_rx_skb(struct gve_priv *priv, struct gve_rx_ring *rx,
 			rx->rx_copied_pkt++;
 			rx->rx_frag_copy_cnt++;
 			rx->rx_copybreak_pkt++;
-		}	u64_stats_update_end(&rx->statss);
+			u64_stats_update_end(&rx->statss);
+		}
 	} else {
 		if (rx->data.raw_addressing) {
 			int recycle = gve_rx_can_recycle_buffer(page_info);
-- 
2.20.1

Re: [PATCH net-next] gve: fix unmatched u64_stats_update_end()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-10 14:50:13

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Wed, 10 Nov 2021 11:11:09 +0300 you wrote:
The u64_stats_update_end() call is supposed to be inside the curly
braces so it pairs with the u64_stats_update_begin().

Fixes: 37149e9374bf ("gve: Implement packet continuation for RX.")
Signed-off-by: Dan Carpenter <redacted>
---
Based on the indenting.  Not tested.

[...]
Here is the summary with links:
  - [net-next] gve: fix unmatched u64_stats_update_end()
    https://git.kernel.org/netdev/net/c/721111b1b29c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help