[PATCH net-next] ice: Remove unnecessary casts

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE1723d

2 messages, 2 authors, 2021-11-19 · open the first message on its own page

[PATCH net-next] ice: Remove unnecessary casts

From: Dan Carpenter <hidden>
Date: 2021-11-10 07:50:55

The "bitmap" variable is already an unsigned long so there is no need
for this cast.

Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/ethernet/intel/ice/ice_sched.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c b/drivers/net/ethernet/intel/ice/ice_sched.c
index ce3c7bded4cb..61c3f88d6ed2 100644
--- a/drivers/net/ethernet/intel/ice/ice_sched.c
+++ b/drivers/net/ethernet/intel/ice/ice_sched.c
@@ -2661,11 +2661,9 @@ ice_cfg_agg(struct ice_port_info *pi, u32 agg_id, enum ice_agg_type agg_type,
 	enum ice_status status;
 
 	mutex_lock(&pi->sched_lock);
-	status = ice_sched_cfg_agg(pi, agg_id, agg_type,
-				   (unsigned long *)&bitmap);
+	status = ice_sched_cfg_agg(pi, agg_id, agg_type, &bitmap);
 	if (!status)
-		status = ice_save_agg_tc_bitmap(pi, agg_id,
-						(unsigned long *)&bitmap);
+		status = ice_save_agg_tc_bitmap(pi, agg_id, &bitmap);
 	mutex_unlock(&pi->sched_lock);
 	return status;
 }
-- 
2.20.1

RE: [Intel-wired-lan] [PATCH net-next] ice: Remove unnecessary casts

From: G, GurucharanX <hidden>
Date: 2021-11-19 13:23:41

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of Dan
Carpenter
Sent: Wednesday, November 10, 2021 1:20 PM
To: Brandeburg, Jesse <redacted>
Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org; intel-wired-
lan@lists.osuosl.org; Jakub Kicinski [off-list ref]; David S. Miller
[off-list ref]
Subject: [Intel-wired-lan] [PATCH net-next] ice: Remove unnecessary casts

The "bitmap" variable is already an unsigned long so there is no need for this
cast.

Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/ethernet/intel/ice/ice_sched.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Tested-by: Gurucharan G <redacted> (A Contingent worker at Intel)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help