# Re: \[PATCH net v2\] net: phy: phy\_ethtool\_ksettings\_set: Don't discard phy\_start\_aneg's return

- From: Florian Fainelli \<f.fainelli@gmail.com\>
- Date: 2021-11-09 18:29:50 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/11/11215810
- Thread: https://ratatoskr.run/netdev/2021/11/11215670/t.md

```text
On 11/8/21 11:02 AM, Benedikt Spranger wrote:
> On Mon, 8 Nov 2021 19:01:23 +0100
> Heiner Kallweit [ref] wrote:
> 
>> If we would like to support PHY's that don't support all MDI modes
>> then supposedly this would require to add ETHTOOL_LINK_MODE bits for
>> the MDI modes. Then we could use the generic mechanism to check the
>> bits in the "supported" bitmap.
> 
> The things are even worse:
> The chip supports only auto-MDIX at Gigabit and force MDI and
> auto-MDIX in 10/100 modes. No force MDIX at all.

Yes that appears to be correct from my reading of the 53125 datasheet.
Force MDI-X is optional anyway AFAICT
--
Florian
```