# \[RFC PATCH 01/16\] devlink: Remove misleading internal\_flags from health reporter dump - From: Leon Romanovsky \ - Date: 2021-11-08 17:06:03 - List: netdev - Page: https://ratatoskr.run/netdev/2021/11/11215754 - Thread: https://ratatoskr.run/netdev/2021/11/11215750/t.md ```text From: Leon Romanovsky DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET command doesn't have .doit callback and has no use in internal_flags at all. Remove this misleading assignment. Fixes: e44ef4e4516c ("devlink: Hang reporter's dump method on a dumpit cb") Signed-off-by: Leon Romanovsky --- net/core/devlink.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 2d8abe88c673..fb9e60da9a77 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -8836,8 +8836,6 @@ static const struct genl_small_ops devlink_nl_ops[] = { GENL_DONT_VALIDATE_DUMP_STRICT, .dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit, .flags = GENL_ADMIN_PERM, - .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT | - DEVLINK_NL_FLAG_NO_LOCK, }, { .cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR, -- 2.33.1 ```