[PATCH net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF

Subsystems: asix ax88796c spi ethernet adapter, networking drivers, the rest

STALE1768d

2 messages, 2 authors, 2021-11-05 · open the first message on its own page

[PATCH net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-11-04 17:55:39

Build bot says:
quoted
drivers/net/ethernet/asix/ax88796c_main.c:1116:34: warning: unused variable 'ax88796c_dt_ids' [-Wunused-const-variable]
   static const struct of_device_id ax88796c_dt_ids[] = {
                                    ^

The only reference to this array is wrapped in of_match_ptr().

Reported-by: kernel test robot <redacted>
Fixes: a97c69ba4f30 ("net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/ethernet/asix/ax88796c_main.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethernet/asix/ax88796c_main.c
index 4b0c5a09fd57..2086de05385c 100644
--- a/drivers/net/ethernet/asix/ax88796c_main.c
+++ b/drivers/net/ethernet/asix/ax88796c_main.c
@@ -1114,11 +1114,13 @@ static int ax88796c_remove(struct spi_device *spi)
 	return 0;
 }
 
+#ifdef CONFIG_OF
 static const struct of_device_id ax88796c_dt_ids[] = {
 	{ .compatible = "asix,ax88796c" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, ax88796c_dt_ids);
+#endif
 
 static const struct spi_device_id asix_id[] = {
 	{ "ax88796c", 0 },
-- 
2.31.1

Re: [PATCH net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-05 10:50:15

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Thu,  4 Nov 2021 10:55:27 -0700 you wrote:
Build bot says:
quoted
quoted
drivers/net/ethernet/asix/ax88796c_main.c:1116:34: warning: unused variable 'ax88796c_dt_ids' [-Wunused-const-variable]
   static const struct of_device_id ax88796c_dt_ids[] = {
                                    ^

The only reference to this array is wrapped in of_match_ptr().

[...]
Here is the summary with links:
  - [net] net: ax88796c: hide ax88796c_dt_ids if !CONFIG_OF
    https://git.kernel.org/netdev/net/c/6789a4c05127

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help