From: Hangbin Liu <hidden> Date: 2021-11-02 01:37:00
When generating the selftest to another folder, some tests are missing
as they are not added in Makefile. e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
These pathset add them separately to make the Fixes tags less. It would
also make the stable tree or downstream backport easier.
If you think there is no need to add the Fixes tag for this minor issue.
I can repost a new patch and merge all the fixes together.
Thanks
v2: move toeplitz.sh/toeplitz_client.sh under TEST_PROGS_EXTENDED.
Hangbin Liu (5):
kselftests/net: add missed icmp.sh test to Makefile
kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile
kselftests/net: add missed SRv6 tests
kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile
kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile
tools/testing/selftests/net/Makefile | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
--
2.31.1
From: Hangbin Liu <hidden> Date: 2021-11-02 01:37:13
When generating the selftests to another folder, the icmp.sh test will
miss as it is not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Fixes: 7e9838b7915e ("selftests/net: Add icmp.sh for testing ICMP dummy address responses")
Signed-off-by: Hangbin Liu <redacted>
---
tools/testing/selftests/net/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Hangbin Liu <hidden> Date: 2021-11-02 01:37:17
When generating the selftests to another folder, the include file
setup_loopback.sh/setup_veth.sh for gro.sh/gre_gro.sh are missing as
they are not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test")
Fixes: 9af771d2ec04 ("selftests/net: allow GRO coalesce test on veth")
Signed-off-by: Hangbin Liu <redacted>
---
tools/testing/selftests/net/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Hangbin Liu <hidden> Date: 2021-11-02 01:37:21
When generating the selftests to another folder, the SRv6 tests are
missing as they are not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Fixes: 03a0b567a03d ("selftests: seg6: add selftest for SRv6 End.DT46 Behavior")
Fixes: 2195444e09b4 ("selftests: add selftest for the SRv6 End.DT4 behavior")
Fixes: 2bc035538e16 ("selftests: add selftest for the SRv6 End.DT6 (VRF) behavior")
Signed-off-by: Hangbin Liu <redacted>
---
tools/testing/selftests/net/Makefile | 3 +++
1 file changed, 3 insertions(+)
From: Hangbin Liu <hidden> Date: 2021-11-02 01:37:28
When generating the selftests to another folder, the
vrf_strict_mode_test.sh test will miss as it is not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Fixes: 8735e6eaa438 ("selftests: add selftest for the VRF strict mode")
Signed-off-by: Hangbin Liu <redacted>
---
tools/testing/selftests/net/Makefile | 1 +
1 file changed, 1 insertion(+)
From: Hangbin Liu <hidden> Date: 2021-11-02 01:37:35
When generating the selftests to another folder, the toeplitz.sh
and toeplitz_client.sh are missing as they are not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
and are not intended to be run from kselftests.
Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
Signed-off-by: Hangbin Liu <redacted>
---
v2: move the tests under TEST_PROGS_EXTENDED as Willem suggested.
---
tools/testing/selftests/net/Makefile | 1 +
1 file changed, 1 insertion(+)
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com> Date: 2021-11-02 15:10:27
On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu [off-list ref] wrote:
When generating the selftests to another folder, the toeplitz.sh
and toeplitz_client.sh are missing as they are not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
and are not intended to be run from kselftests.
Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
Signed-off-by: Hangbin Liu <redacted>
Reviewed-by: Willem de Bruijn <willemb@google.com>
The same might apply to the icmp and vrf tests? I am not familiar with those.
From: Jakub Kicinski <kuba@kernel.org> Date: 2021-11-02 18:16:35
On Tue, 2 Nov 2021 09:36:31 +0800 Hangbin Liu wrote:
When generating the selftest to another folder, some tests are missing
as they are not added in Makefile. e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
These pathset add them separately to make the Fixes tags less. It would
also make the stable tree or downstream backport easier.
If you think there is no need to add the Fixes tag for this minor issue.
I can repost a new patch and merge all the fixes together.
Thanks! Could you rebase on latest net/master and resend?
We just forwarded the net tree for the next merge window.
From: Hangbin Liu <hidden> Date: 2021-11-03 02:43:01
On Tue, Nov 02, 2021 at 11:09:43AM -0400, Willem de Bruijn wrote:
On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu [off-list ref] wrote:
quoted
When generating the selftests to another folder, the toeplitz.sh
and toeplitz_client.sh are missing as they are not in Makefile, e.g.
make -C tools/testing/selftests/ install \
TARGETS="net" INSTALL_PATH=/tmp/kselftests
Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
and are not intended to be run from kselftests.
Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
Signed-off-by: Hangbin Liu <redacted>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Thanks for the review.
The same might apply to the icmp and vrf tests? I am not familiar with those.
icmp and vrf are running for selftests. They should be added to TEST_PROGS.
Thanks
Hangbin