# RE: \[PATHC bpf v5 2/3\] selftests, bpf: Fix test\_txmsg\_ingress\_parser error

- From: John Fastabend \<john.fastabend@gmail.com\>
- Date: 2021-10-22 15:22:45 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/10/7783320
- Thread: https://ratatoskr.run/netdev/2021/10/7782397/t.md

```text
Liu Jian wrote:
> After "skmsg: lose offset info in sk_psock_skb_ingress", the test case
> with ktls failed. This because ktls parser(tls_read_size) return value
> is 285 not 256.
> 
> the case like this:
> 	tls_sk1 --> redir_sk --> tls_sk2
> tls_sk1 sent out 512 bytes data, after tls related processing redir_sk
> recved 570 btyes data, and redirect 512 (skb_use_parser) bytes data to
> tls_sk2; but tls_sk2 needs 285 * 2 bytes data, receive timeout occurred.
> 
> Signed-off-by: Liu Jian <redacted>
> ---
>  tools/testing/selftests/bpf/test_sockmap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
> index eefd445b96fc..06924917ad77 100644
> --- a/tools/testing/selftests/bpf/test_sockmap.c
> +++ b/tools/testing/selftests/bpf/test_sockmap.c
> @@ -1680,6 +1680,8 @@ static void test_txmsg_ingress_parser(int cgrp, struct sockmap_options *opt)
>  {
>  	txmsg_pass = 1;
>  	skb_use_parser = 512;
> +	if (ktls == 1)
> +		skb_use_parser = 570;
>  	opt->iov_length = 256;
>  	opt->iov_count = 1;
>  	opt->rate = 2;
> -- 
> 2.17.1
> 

Hi Liu LGTM sorry about the delay there I thought I acked this already, but
guess now.

Acked-by: John Fastabend <john.fastabend@gmail.com>
```